ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-02-22 10:20:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Authenticate writes!

Browse Source
This commit is contained in:
Itamar Turner-Trauring 2022-03-09 10:22:00 -05:00
parent c642218173
commit 92b952a5fe
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/allmydata/storage/http_server.py
View File

@ -167,8 +167,8 @@ class UploadsInProgress(object):
self, storage_index: bytes, share_number: int, upload_secret: bytes self, storage_index: bytes, share_number: int, upload_secret: bytes
) -> BucketWriter: ) -> BucketWriter:
"""Get the given in-progress immutable share upload.""" """Get the given in-progress immutable share upload."""
self.validate_upload_secret(storage_index, share_number, upload_secret)
try: try:
# TODO 3877 check the upload secret matches given one
return self._uploads[storage_index].shares[share_number] return self._uploads[storage_index].shares[share_number]
except (KeyError, IndexError): except (KeyError, IndexError):
raise _HTTPError(http.NOT_FOUND) raise _HTTPError(http.NOT_FOUND)
@ -345,8 +345,6 @@ class HTTPServer(object):
offset = content_range.start offset = content_range.start
# TODO 3877 test for checking upload secret
# TODO limit memory usage # TODO limit memory usage
# https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3872 # https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3872
data = request.content.read(content_range.stop - content_range.start + 1) data = request.content.read(content_range.stop - content_range.start + 1)

15
src/allmydata/test/test_storage_http.py
View File

@ -474,6 +474,21 @@ class ImmutableHTTPAPITests(SyncTestCase):
) )
self.assertEqual(downloaded, expected_data[offset : offset + length]) self.assertEqual(downloaded, expected_data[offset : offset + length])
def test_write_with_wrong_upload_key(self):
"""A write with the wrong upload key fails."""
(upload_secret, _, storage_index, _) = self.create_upload({1}, 100)
with self.assertRaises(ClientException) as e:
result_of(
self.imm_client.write_share_chunk(
storage_index,
1,
upload_secret + b"X",
0,
b"123",
)
)
self.assertEqual(e.exception.args[0], http.UNAUTHORIZED)
def test_allocate_buckets_second_time_wrong_upload_key(self): def test_allocate_buckets_second_time_wrong_upload_key(self):
""" """
If allocate buckets endpoint is called second time with wrong upload If allocate buckets endpoint is called second time with wrong upload