From 8d31ebe09ea3c4343fae6c2331497152a51b27e4 Mon Sep 17 00:00:00 2001 From: Florian Sesser Date: Mon, 18 Nov 2024 09:57:34 +0000 Subject: [PATCH] Revert "MyPy in tests: Ignore StubTreq being a stub and not having all the attrs" This reverts commit 7efc31d55246fdf57968862c6f36fa34c2a14585. Greetings @meejah! This is mostly to show you (in CI) the type error that MyPy reports for StubTreq in the tests and that it has nothing to do with the earlier changing changing type annotations in the code. --- src/allmydata/test/test_storage_http.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/allmydata/test/test_storage_http.py b/src/allmydata/test/test_storage_http.py index 32fcd084b..185cfa995 100644 --- a/src/allmydata/test/test_storage_http.py +++ b/src/allmydata/test/test_storage_http.py @@ -716,7 +716,7 @@ class GenericHTTPAPITests(SyncTestCase): """ client = StubTreq(self.http.http_server.get_resource()) response = self.http.result_of_with_flush( - client.request( # type: ignore[attr-defined] + client.request( "GET", "http://127.0.0.1/storage/v1/version", ),