Merge pull request #486 from exarkun/2915.disable-hypothesis-deadline

Disable hypothesis deadline and "too slow" health check on CI

.travis.yml

@@ -7,6 +7,10 @@ before_cache:
 git:
   depth: 1000
 
+env:
+  global:
+    - TAHOE_LAFS_HYPOTHESIS_PROFILE=ci
+
 install:
 # ~/.local/bin is on $PATH by default, but on OS-X, --user puts it elsewhere
   - if [ "${TRAVIS_OS_NAME}" = "osx" ]; then export PATH=$HOME/Library/Python/2.7/bin:$PATH; fi

src/allmydata/test/__init__.py

@@ -25,6 +25,34 @@ def disable_foolscap_incidents():
 # we disable incident reporting for all unit tests.
 disable_foolscap_incidents()
 
+
+def _configure_hypothesis():
+    from os import environ
+
+    from hypothesis import (
+        HealthCheck,
+        settings,
+    )
+
+    settings.register_profile(
+        "ci",
+        suppress_health_check=[
+            # CPU resources available to CI builds typically varies
+            # significantly from run to run making it difficult to determine
+            # if "too slow" data generation is a result of the code or the
+            # execution environment.  Prevent these checks from
+            # (intermittently) failing tests that are otherwise fine.
+            HealthCheck.too_slow,
+        ],
+        # With the same reasoning, disable the test deadline.
+        deadline=None,
+    )
+
+    profile_name = environ.get("TAHOE_LAFS_HYPOTHESIS_PROFILE", "default")
+    settings.load_profile(profile_name)
+_configure_hypothesis()
+
+
 import sys
 if sys.platform == "win32":
     from allmydata.windows.fixups import initialize

src/allmydata/test/test_happiness.py

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 
 from twisted.trial import unittest
-from hypothesis import given, settings, HealthCheck
+from hypothesis import given
 from hypothesis.strategies import text, sets
 from allmydata.immutable import happiness_upload
 
@@ -225,7 +225,6 @@ class PlacementTests(unittest.TestCase):
         sets(elements=text(min_size=1, max_size=30), min_size=4, max_size=4),
         sets(elements=text(min_size=1, max_size=30), min_size=4),
     )
-    @settings(suppress_health_check=[HealthCheck.too_slow])
     def test_hypothesis_unhappy(self, peers, shares):
         """
         similar to test_unhappy we test that the resulting happiness is
@@ -245,7 +244,6 @@ class PlacementTests(unittest.TestCase):
         # can we make a readonly_peers that's a subset of           ^
         sets(elements=text(min_size=1, max_size=30), min_size=1, max_size=20),
     )
-    @settings(suppress_health_check=[HealthCheck.too_slow])
     def test_more_hypothesis(self, peers, shares):
         """
         similar to test_unhappy we test that the resulting happiness is

tox.ini

@@ -13,7 +13,7 @@ skipsdist = True
 
 [testenv]
 basepython=python2.7
-passenv = TAHOE_LAFS_TRIAL_ARGS USERPROFILE HOMEDRIVE HOMEPATH
+passenv = TAHOE_LAFS_* USERPROFILE HOMEDRIVE HOMEPATH
 # Pre-install "incremental" to avoid bug #2913. Basically if Twisted's
 # setup_requires=["incremental"] causes this to be installed (with
 # setuptools), then it'll fail on travis's OS-X 10.12 machines when PyPI