From ec449970eef7baacb80fd67fd82318f3b4f491f6 Mon Sep 17 00:00:00 2001 From: May-Lee Sia Date: Thu, 29 Apr 2021 07:56:27 +0200 Subject: [PATCH 1/3] Add CONTRIBUTORS.rst --- contributors.rst | 43 ++++++++++++++++++++++++++++++++ newsfragments/3682.documentation | 1 + 2 files changed, 44 insertions(+) create mode 100644 contributors.rst create mode 100644 newsfragments/3682.documentation diff --git a/contributors.rst b/contributors.rst new file mode 100644 index 000000000..bde4b014d --- /dev/null +++ b/contributors.rst @@ -0,0 +1,43 @@ +Contributor Checklist +===================== + + +* Create a ``Trac`` ticket, fill it out and assign it to yourself (contact exarkun if you don't have an account): + + ``https://tahoe-lafs.org/trac/tahoe-lafs/newticket`` + +* Use the ticket number to name your branch (example): + + ``3003.contributor-guide`` + +* Good idea to add tests at the same time you write your code. + +* Add a file to the ``/newsfragments`` folder, named with the ticket number and the type of patch (example): + + ``newsfragments/3651.minor`` + +* ``towncrier`` recognizes the following types: + + ``incompat``, ``feature``, ``bugfix``, ``installation``, ``configuration``, ``documentation``, ``removed``, ``other``, ``minor`` +* Add one sentence to ``newsfragments/.`` describing the change (example): + + ``The integration test suite has been updated to use pytest-twisted instead of deprecated pytest APIs.`` + +* Run the test suite with ``tox``, ``tox -e codechecks`` and ``tox -e typechecks`` + +* Push your branch to Github with your ticket number in the merge commit message (example): + + ``Fixes ticket:3003`` + + This makes the ``Trac`` ticket close when your PR gets approved. + +* Request appropriate review. + + +References +---------- + +This checklist is a summary of `this page on contributing Patches `__ + +Before authoring or reviewing a patch, please familiarize yourself with the `Coding Standard `__ +and the `Contributor Code of Conduct `__. diff --git a/newsfragments/3682.documentation b/newsfragments/3682.documentation new file mode 100644 index 000000000..74c4cf246 --- /dev/null +++ b/newsfragments/3682.documentation @@ -0,0 +1 @@ +A cheatsheet-style document for contributors was created at CONTRIBUTORS.md From db65b3d69b6f79fef257fc4b67b3861e3d473eb8 Mon Sep 17 00:00:00 2001 From: May-Lee Sia Date: Thu, 29 Apr 2021 08:00:13 +0200 Subject: [PATCH 2/3] Clean up some files --- contributors.rst => CONTRIBUTORS.rst | 0 newsfragments/3682.documentation | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename contributors.rst => CONTRIBUTORS.rst (100%) diff --git a/contributors.rst b/CONTRIBUTORS.rst similarity index 100% rename from contributors.rst rename to CONTRIBUTORS.rst diff --git a/newsfragments/3682.documentation b/newsfragments/3682.documentation index 74c4cf246..5cf78bd90 100644 --- a/newsfragments/3682.documentation +++ b/newsfragments/3682.documentation @@ -1 +1 @@ -A cheatsheet-style document for contributors was created at CONTRIBUTORS.md +A cheatsheet-style document for contributors was created at CONTRIBUTORS.rst \ No newline at end of file From 9c7f943271d028373f8967407477121a4cd0e6a2 Mon Sep 17 00:00:00 2001 From: May-Lee Sia Date: Fri, 7 May 2021 16:10:24 +0200 Subject: [PATCH 3/3] Add suggestion for Tahoe Committers --- CONTRIBUTORS.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst index bde4b014d..70d308398 100644 --- a/CONTRIBUTORS.rst +++ b/CONTRIBUTORS.rst @@ -31,8 +31,7 @@ Contributor Checklist This makes the ``Trac`` ticket close when your PR gets approved. -* Request appropriate review. - +* Request appropriate review - we suggest asking `Tahoe Committers `__ References ----------