ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-01-14 08:49:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update tests for ResultsRenderer classes

Browse Source
This commit is contained in:
Sajith Sasidharan 2020-06-11 12:44:48 -04:00
parent 0d1269264a
commit 77120ba70c
1 changed files with 61 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

98
src/allmydata/test/test_checker.py
View File

@ -3,6 +3,13 @@ import json
import os.path, shutil import os.path, shutil
from twisted.trial import unittest from twisted.trial import unittest
from twisted.internet import defer from twisted.internet import defer
from nevow.inevow import IRequest
from zope.interface import implementer
from twisted.web.server import Request
from twisted.web.test.requesthelper import DummyChannel
from twisted.web.template import flattenString
from allmydata import check_results, uri from allmydata import check_results, uri
from allmydata import uri as tahoe_uri from allmydata import uri as tahoe_uri
from allmydata.util import base32 from allmydata.util import base32
@ -23,6 +30,17 @@ class FakeClient(object):
def get_storage_broker(self): def get_storage_broker(self):
return self.storage_broker return self.storage_broker
# XXX: We have to have this class because `common.get_arg()` expects a
# `nevow.inevow.IRequest`, which `twisted.web.server.Request` isn't.
# Also, the request needs to have `args` and `fields` properties so
# that `allmydata.web.common.get_arg()` won't complain.
@implementer(IRequest)
class TestRequest(Request):
def __init__(self, args=None, fields=None):
Request.__init__(self, DummyChannel())
self.args = args or {}
self.fields = fields or {}
class WebResultsRendering(unittest.TestCase, WebRenderingMixin): class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
def create_fake_client(self): def create_fake_client(self):
@ -51,34 +69,39 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
c.storage_broker = sb c.storage_broker = sb
return c return c
def render_json(self, page): def render_json(self, resource):
d = self.render1(page, args={"output": ["json"]}) return resource.render(TestRequest(args={"output": ["json"]}))
return d
def render_element(self, element, args=None):
d = flattenString(TestRequest(args), element)
return unittest.TestCase().successResultOf(d)
def test_literal(self): def test_literal(self):
c = self.create_fake_client() lcr = web_check_results.LiteralCheckResultsElement()
lcr = web_check_results.LiteralCheckResultsRenderer(c)
d = self.render1(lcr) d = self.render_element(lcr)
def _check(html): def _check(html):
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("Literal files are always healthy", s) self.failUnlessIn("Literal files are always healthy", s)
d.addCallback(_check) _check(d)
d.addCallback(lambda ignored:
self.render1(lcr, args={"return_to": ["FOOURL"]})) d = self.render_element(lcr, args={"return_to": ["FOOURL"]})
def _check_return_to(html): def _check_return_to(html):
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("Literal files are always healthy", s) self.failUnlessIn("Literal files are always healthy", s)
self.failUnlessIn('<a href="FOOURL">Return to file.</a>', self.failUnlessIn('<a href="FOOURL">Return to file.</a>',
html) html)
d.addCallback(_check_return_to) _check_return_to(d)
d.addCallback(lambda ignored: self.render_json(lcr))
c = self.create_fake_client()
lcr = web_check_results.LiteralCheckResultsRenderer(c)
d = self.render_json(lcr)
def _check_json(js): def _check_json(js):
j = json.loads(js) j = json.loads(js)
self.failUnlessEqual(j["storage-index"], "") self.failUnlessEqual(j["storage-index"], "")
self.failUnlessEqual(j["results"]["healthy"], True) self.failUnlessEqual(j["results"]["healthy"], True)
d.addCallback(_check_json) _check_json(d)
return d
def test_check(self): def test_check(self):
c = self.create_fake_client() c = self.create_fake_client()
@ -108,8 +131,8 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
healthy=True, recoverable=True, healthy=True, recoverable=True,
summary="groovy", summary="groovy",
**data) **data)
w = web_check_results.CheckResultsRenderer(c, cr) w = web_check_results.CheckResultsRendererElement(c, cr)
html = self.render2(w) html = self.render_element(w)
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check Results for SI=2k6avp", s) # abbreviated self.failUnlessIn("File Check Results for SI=2k6avp", s) # abbreviated
self.failUnlessIn("Healthy : groovy", s) self.failUnlessIn("Healthy : groovy", s)
@ -126,8 +149,8 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
healthy=False, recoverable=True, healthy=False, recoverable=True,
summary="ungroovy", summary="ungroovy",
**data) **data)
w = web_check_results.CheckResultsRenderer(c, cr) w = web_check_results.CheckResultsRendererElement(c, cr)
html = self.render2(w) html = self.render_element(w)
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check Results for SI=2k6avp", s) # abbreviated self.failUnlessIn("File Check Results for SI=2k6avp", s) # abbreviated
self.failUnlessIn("Not Healthy! : ungroovy", s) self.failUnlessIn("Not Healthy! : ungroovy", s)
@ -138,22 +161,23 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
healthy=False, recoverable=False, healthy=False, recoverable=False,
summary="rather dead", summary="rather dead",
**data) **data)
w = web_check_results.CheckResultsRenderer(c, cr) w = web_check_results.CheckResultsRendererElement(c, cr)
html = self.render2(w) html = self.render_element(w)
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check Results for SI=2k6avp", s) # abbreviated self.failUnlessIn("File Check Results for SI=2k6avp", s) # abbreviated
self.failUnlessIn("Not Recoverable! : rather dead", s) self.failUnlessIn("Not Recoverable! : rather dead", s)
self.failUnlessIn("Corrupt shares: Share ID Nickname Node ID sh#2 peer-0 00000000", s) self.failUnlessIn("Corrupt shares: Share ID Nickname Node ID sh#2 peer-0 00000000", s)
html = self.render2(w) html = self.render_element(w)
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check Results for SI=2k6avp", s) # abbreviated self.failUnlessIn("File Check Results for SI=2k6avp", s) # abbreviated
self.failUnlessIn("Not Recoverable! : rather dead", s) self.failUnlessIn("Not Recoverable! : rather dead", s)
html = self.render2(w, args={"return_to": ["FOOURL"]}) html = self.render_element(w, args={"return_to": ["FOOURL"]})
self.failUnlessIn('<a href="FOOURL">Return to file/directory.</a>', self.failUnlessIn('<a href="FOOURL">Return to file/directory.</a>',
html) html)
w = web_check_results.CheckResultsRenderer(c, cr)
d = self.render_json(w) d = self.render_json(w)
def _check_json(jdata): def _check_json(jdata):
j = json.loads(jdata) j = json.loads(jdata)
@ -178,15 +202,15 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
'recoverable': False, 'recoverable': False,
} }
self.failUnlessEqual(j["results"], expected) self.failUnlessEqual(j["results"], expected)
d.addCallback(_check_json) _check_json(d)
d.addCallback(lambda ignored: self.render1(w))
w = web_check_results.CheckResultsRendererElement(c, cr)
d = self.render_element(w)
def _check(html): def _check(html):
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check Results for SI=2k6avp", s) self.failUnlessIn("File Check Results for SI=2k6avp", s)
self.failUnlessIn("Not Recoverable! : rather dead", s) self.failUnlessIn("Not Recoverable! : rather dead", s)
d.addCallback(_check) _check(html)
return d
def test_check_and_repair(self): def test_check_and_repair(self):
c = self.create_fake_client() c = self.create_fake_client()
@ -244,8 +268,8 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
crr.post_repair_results = post_cr crr.post_repair_results = post_cr
crr.repair_attempted = False crr.repair_attempted = False
w = web_check_results.CheckAndRepairResultsRenderer(c, crr) w = web_check_results.CheckAndRepairResultsRendererElement(c, crr)
html = self.render2(w) html = self.render_element(w)
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check-And-Repair Results for SI=2k6avp", s) self.failUnlessIn("File Check-And-Repair Results for SI=2k6avp", s)
@ -256,7 +280,7 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
crr.repair_attempted = True crr.repair_attempted = True
crr.repair_successful = True crr.repair_successful = True
html = self.render2(w) html = self.render_element(w)
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check-And-Repair Results for SI=2k6avp", s) self.failUnlessIn("File Check-And-Repair Results for SI=2k6avp", s)
@ -271,7 +295,7 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
summary="better", summary="better",
**data) **data)
crr.post_repair_results = post_cr crr.post_repair_results = post_cr
html = self.render2(w) html = self.render_element(w)
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check-And-Repair Results for SI=2k6avp", s) self.failUnlessIn("File Check-And-Repair Results for SI=2k6avp", s)
@ -286,7 +310,7 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
summary="worse", summary="worse",
**data) **data)
crr.post_repair_results = post_cr crr.post_repair_results = post_cr
html = self.render2(w) html = self.render_element(w)
s = self.remove_tags(html) s = self.remove_tags(html)
self.failUnlessIn("File Check-And-Repair Results for SI=2k6avp", s) self.failUnlessIn("File Check-And-Repair Results for SI=2k6avp", s)
@ -294,7 +318,8 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
self.failUnlessIn("Repair unsuccessful", s) self.failUnlessIn("Repair unsuccessful", s)
self.failUnlessIn("Post-Repair Checker Results:", s) self.failUnlessIn("Post-Repair Checker Results:", s)
d = self.render_json(w) w2 = web_check_results.CheckAndRepairResultsRenderer(c, crr)
d = self.render_json(w2)
def _got_json(data): def _got_json(data):
j = json.loads(data) j = json.loads(data)
self.failUnlessEqual(j["repair-attempted"], True) self.failUnlessEqual(j["repair-attempted"], True)
@ -302,16 +327,15 @@ class WebResultsRendering(unittest.TestCase, WebRenderingMixin):
"2k6avpjga3dho3zsjo6nnkt7n4") "2k6avpjga3dho3zsjo6nnkt7n4")
self.failUnlessEqual(j["pre-repair-results"]["summary"], "illing") self.failUnlessEqual(j["pre-repair-results"]["summary"], "illing")
self.failUnlessEqual(j["post-repair-results"]["summary"], "worse") self.failUnlessEqual(j["post-repair-results"]["summary"], "worse")
d.addCallback(_got_json) _got_json(d)
w2 = web_check_results.CheckAndRepairResultsRenderer(c, None) w3 = web_check_results.CheckAndRepairResultsRenderer(c, None)
d.addCallback(lambda ignored: self.render_json(w2)) d = self.render_json(w3)
def _got_lit_results(data): def _got_lit_results(data):
j = json.loads(data) j = json.loads(data)
self.failUnlessEqual(j["repair-attempted"], False) self.failUnlessEqual(j["repair-attempted"], False)
self.failUnlessEqual(j["storage-index"], "") self.failUnlessEqual(j["storage-index"], "")
d.addCallback(_got_lit_results) _got_lit_results(d)
return d
class BalancingAct(GridTestMixin, unittest.TestCase): class BalancingAct(GridTestMixin, unittest.TestCase):
# test for #1115 regarding the 'count-good-share-hosts' metric # test for #1115 regarding the 'count-good-share-hosts' metric