From 75410e51f04f90007efce9fa2cba6504c54fe9ac Mon Sep 17 00:00:00 2001
From: meejah <meejah@meejah.ca>
Date: Mon, 25 Oct 2021 21:10:43 -0600
Subject: [PATCH] refactor

---
 src/allmydata/storage/crawler.py | 86 ++++++++++++++++++--------------
 src/allmydata/storage/expirer.py | 14 ++----
 2 files changed, 53 insertions(+), 47 deletions(-)

diff --git a/src/allmydata/storage/crawler.py b/src/allmydata/storage/crawler.py
index 548864e06..2e9bafd13 100644
--- a/src/allmydata/storage/crawler.py
+++ b/src/allmydata/storage/crawler.py
@@ -27,23 +27,14 @@ class TimeSliceExceeded(Exception):
     pass
 
 
-def _convert_pickle_state_to_json(state):
+def _convert_cycle_data(state):
     """
-    :param dict state: the pickled state
+    :param dict state: cycle-to-date or history-item state
 
     :return dict: the state in the JSON form
     """
-    # ["cycle-to-date"]["corrupt-shares"] from 2-tuple to list
-    # ["cycle-to-date"]["leases-per-share-histogram"] gets str keys instead of int
-    # ["cycle-start-finish-times"] from 2-tuple to list
-    # ["configured-expiration-mode"] from 4-tuple to list
-    # ["history"] keys are strings
-    if state["version"] != 1:
-        raise ValueError(
-            "Unknown version {version} in pickle state".format(**state)
-        )
 
-    def convert_cem(value):
+    def _convert_expiration_mode(value):
         # original is a 4-tuple, with the last element being a 2-tuple
         # .. convert both to lists
         return [
@@ -53,41 +44,60 @@ def _convert_pickle_state_to_json(state):
             list(value[3]),
         ]
 
-    def convert_ctd(value):
-        ctd_converter = {
-            "lease-age-histogram": lambda value: {
+    def _convert_lease_age(value):
+        # if we're in cycle-to-date, this is a dict
+        if isinstance(value, dict):
+            return {
                 "{},{}".format(k[0], k[1]): v
                 for k, v in value.items()
-            },
-            "corrupt-shares": lambda value: [
-                list(x)
-                for x in value
-            ],
-        }
-        return {
-            k: ctd_converter.get(k, lambda z: z)(v)
-            for k, v in value.items()
-        }
+            }
+        # otherwise, it's a history-item and they're 3-tuples
+        return [
+            list(v)
+            for v in value
+        ]
 
-    # we don't convert "history" here because that's in a separate
-    # file; see expirer.py
     converters = {
-        "cycle-to-date": convert_ctd,
-        "cycle-starte-finish-times": list,
-        "configured-expiration-mode": convert_cem,
+        "configured-expiration-mode": _convert_expiration_mode,
+        "cycle-start-finish-times": list,
+        "lease-age-histogram": _convert_lease_age,
+        "corrupt-shares": lambda value: [
+            list(x)
+            for x in value
+        ],
+        "leases-per-share-histogram": lambda value: {
+            str(k): v
+            for k, v in value.items()
+        },
+    }
+    return {
+            k: converters.get(k, lambda z: z)(v)
+            for k, v in state.items()
     }
 
-    def convert_value(key, value):
-        converter = converters.get(key, None)
-        if converter is None:
-            return value
-        return converter(value)
 
-    new_state = {
-        k: convert_value(k, v)
+def _convert_pickle_state_to_json(state):
+    """
+    :param dict state: the pickled state
+
+    :return dict: the state in the JSON form
+    """
+    # ["cycle-to-date"]["corrupt-shares"] from 2-tuple to list
+    # ["cycle-to-date"]["leases-per-share-histogram"] gets str keys instead of int
+    # ["cycle-start-finish-times"] from 2-tuple to list
+    # ["history"] keys are strings
+    if state["version"] != 1:
+        raise ValueError(
+            "Unknown version {version} in pickle state".format(**state)
+        )
+
+    converters = {
+        "cycle-to-date": _convert_cycle_data,
+    }
+    return {
+        k: converters.get(k, lambda x: x)(v)
         for k, v in state.items()
     }
-    return new_state
 
 
 def _maybe_upgrade_pickle_to_json(state_path, convert_pickle):
diff --git a/src/allmydata/storage/expirer.py b/src/allmydata/storage/expirer.py
index ce126b6a4..946498eaf 100644
--- a/src/allmydata/storage/expirer.py
+++ b/src/allmydata/storage/expirer.py
@@ -13,6 +13,7 @@ import struct
 from allmydata.storage.crawler import (
     ShareCrawler,
     _maybe_upgrade_pickle_to_json,
+    _convert_cycle_data,
 )
 from allmydata.storage.shares import get_share_file
 from allmydata.storage.common import UnknownMutableContainerVersionError, \
@@ -30,15 +31,10 @@ def _convert_pickle_state_to_json(state):
 
     :return dict: the state in the JSON form
     """
-    print("CONVERT", state)
-    for k, v in state.items():
-        print(k, v)
-    if state["version"] != 1:
-        raise ValueError(
-            "Unknown version {version} in pickle state".format(**state)
-        )
-
-    return state
+    return {
+        str(k): _convert_cycle_data(v)
+        for k, v in state.items()
+    }
 
 
 class _HistorySerializer(object):