ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-04-07 10:56:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Back out subunit2junitxml exit status change from ticket:3336

Browse Source 
I don't know why I included this change.  It was certainly based on a faulty
assumption (that the tox command would exit with error if a test failed - it
won't).  Apart from that, the motivation was the Python 3.6 ratchet job.  The
test run was expected to fail but then the *ratchet* tool was in charge of
deciding if this indicated real failure or not.  Failing at this point
prevented that logic from running.  Now the ratchet is gone and we want CI to
turn red if anything fails.
This commit is contained in:
Jean-Paul Calderone 2020-08-14 13:10:54 -04:00
parent 41fe405068
commit 6eba1469f3
No known key found for this signature in database
GPG Key ID: 86E6F8BAE797C287
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.circleci/run-tests.sh
View File

@ -88,9 +88,5 @@ if [ -n "${ARTIFACTS}" ]; then
# Create a junitxml results area.
mkdir -p "$(dirname "${JUNITXML}")"
# Always succeed even if subunit2junitxml fails. subunit2junitxml signals
# failure if the stream it is processing contains test failures. This is
# not what we care about. If we cared about it, the test command above
# would have signalled failure already and we wouldn't be here.
"${BOOTSTRAP_VENV}"/bin/subunit2junitxml < "${SUBUNIT2}" > "${JUNITXML}" || true
"${BOOTSTRAP_VENV}"/bin/subunit2junitxml < "${SUBUNIT2}" > "${JUNITXML}" || "${alternative}"
fi