From 6c18983f7b182fe696dd466dab517312692c1648 Mon Sep 17 00:00:00 2001
From: Florian Sesser <florian@private.storage>
Date: Fri, 10 Sep 2021 13:13:13 +0000
Subject: [PATCH] OpenMetrics test: Use realistic input data

---
 src/allmydata/test/test_openmetrics.py | 92 +++++++++++++++++++++++++-
 1 file changed, 89 insertions(+), 3 deletions(-)

diff --git a/src/allmydata/test/test_openmetrics.py b/src/allmydata/test/test_openmetrics.py
index cd5c5d407..c7e26213a 100644
--- a/src/allmydata/test/test_openmetrics.py
+++ b/src/allmydata/test/test_openmetrics.py
@@ -5,7 +5,95 @@ from allmydata.web.status import Statistics
 
 class FakeStatsProvider(object):
     def get_stats(self):
-        stats = {'stats': {}, 'counters': {}}
+        # Parsed into a dict from a running tahoe's /statistics?t=json
+        stats = {'stats': {
+           'storage_server.latencies.get.99_9_percentile': None,
+           'storage_server.latencies.close.10_0_percentile': 0.00021910667419433594,
+           'storage_server.latencies.read.01_0_percentile': 2.8848648071289062e-05,
+           'storage_server.latencies.writev.99_9_percentile': None,
+           'storage_server.latencies.read.99_9_percentile': None,
+           'storage_server.latencies.allocate.99_0_percentile': 0.000988006591796875,
+           'storage_server.latencies.writev.mean': 0.00045332245070571654,
+           'storage_server.latencies.close.99_9_percentile': None,
+           'cpu_monitor.15min_avg': 0.00017592000079223033,
+           'storage_server.disk_free_for_root': 103289454592,
+           'storage_server.latencies.get.99_0_percentile': 0.000347137451171875,
+           'storage_server.latencies.get.mean': 0.00021158285060171353,
+           'storage_server.latencies.read.90_0_percentile': 8.893013000488281e-05,
+           'storage_server.latencies.write.01_0_percentile': 3.600120544433594e-05,
+           'storage_server.latencies.write.99_9_percentile': 0.00017690658569335938,
+           'storage_server.latencies.close.90_0_percentile': 0.00033211708068847656,
+           'storage_server.disk_total': 103497859072,
+           'storage_server.latencies.close.95_0_percentile': 0.0003509521484375,
+           'storage_server.latencies.readv.samplesize': 1000,
+           'storage_server.disk_free_for_nonroot': 103289454592,
+           'storage_server.latencies.close.mean': 0.0002715024480059103,
+           'storage_server.latencies.writev.95_0_percentile': 0.0007410049438476562,
+           'storage_server.latencies.readv.90_0_percentile': 0.0003781318664550781,
+           'storage_server.latencies.readv.99_0_percentile': 0.0004050731658935547,
+           'storage_server.latencies.allocate.mean': 0.0007128627429454784,
+           'storage_server.latencies.close.samplesize': 326,
+           'storage_server.latencies.get.50_0_percentile': 0.0001819133758544922,
+           'storage_server.latencies.write.50_0_percentile': 4.482269287109375e-05,
+           'storage_server.latencies.readv.01_0_percentile': 0.0002970695495605469,
+           'storage_server.latencies.get.10_0_percentile': 0.00015687942504882812,
+           'storage_server.latencies.allocate.90_0_percentile': 0.0008189678192138672,
+           'storage_server.latencies.get.samplesize': 472,
+           'storage_server.total_bucket_count': 393,
+           'storage_server.latencies.read.mean': 5.936201880959903e-05,
+           'storage_server.latencies.allocate.01_0_percentile': 0.0004208087921142578,
+           'storage_server.latencies.allocate.99_9_percentile': None,
+           'storage_server.latencies.readv.mean': 0.00034061360359191893,
+           'storage_server.disk_used': 208404480,
+           'storage_server.latencies.allocate.50_0_percentile': 0.0007410049438476562,
+           'storage_server.latencies.read.99_0_percentile': 0.00011992454528808594,
+           'node.uptime': 3805759.8545179367,
+           'storage_server.latencies.writev.10_0_percentile': 0.00035190582275390625,
+           'storage_server.latencies.writev.90_0_percentile': 0.0006821155548095703,
+           'storage_server.latencies.close.01_0_percentile': 0.00021505355834960938,
+           'storage_server.latencies.close.50_0_percentile': 0.0002579689025878906,
+           'cpu_monitor.1min_avg': 0.0002130000000003444,
+           'storage_server.latencies.writev.50_0_percentile': 0.0004138946533203125,
+           'storage_server.latencies.read.95_0_percentile': 9.107589721679688e-05,
+           'storage_server.latencies.readv.95_0_percentile': 0.0003859996795654297,
+           'storage_server.latencies.write.10_0_percentile': 3.719329833984375e-05,
+           'storage_server.accepting_immutable_shares': 1,
+           'storage_server.latencies.writev.samplesize': 309,
+           'storage_server.latencies.get.95_0_percentile': 0.0003190040588378906,
+           'storage_server.latencies.readv.10_0_percentile': 0.00032210350036621094,
+           'storage_server.latencies.get.90_0_percentile': 0.0002999305725097656,
+           'storage_server.latencies.get.01_0_percentile': 0.0001239776611328125,
+           'cpu_monitor.total': 641.4941180000001,
+           'storage_server.latencies.write.samplesize': 1000,
+           'storage_server.latencies.write.95_0_percentile': 9.489059448242188e-05,
+           'storage_server.latencies.read.50_0_percentile': 6.890296936035156e-05,
+           'storage_server.latencies.writev.01_0_percentile': 0.00033211708068847656,
+           'storage_server.latencies.read.10_0_percentile': 3.0994415283203125e-05,
+           'storage_server.latencies.allocate.10_0_percentile': 0.0004949569702148438,
+           'storage_server.reserved_space': 0,
+           'storage_server.disk_avail': 103289454592,
+           'storage_server.latencies.write.99_0_percentile': 0.00011301040649414062,
+           'storage_server.latencies.write.90_0_percentile': 9.083747863769531e-05,
+           'cpu_monitor.5min_avg': 0.0002370666691157502,
+           'storage_server.latencies.write.mean': 5.8008909225463864e-05,
+           'storage_server.latencies.readv.50_0_percentile': 0.00033020973205566406,
+           'storage_server.latencies.close.99_0_percentile': 0.0004038810729980469,
+           'storage_server.allocated': 0,
+           'storage_server.latencies.writev.99_0_percentile': 0.0007710456848144531,
+           'storage_server.latencies.readv.99_9_percentile': 0.0004780292510986328,
+           'storage_server.latencies.read.samplesize': 170,
+           'storage_server.latencies.allocate.samplesize': 406,
+           'storage_server.latencies.allocate.95_0_percentile': 0.0008411407470703125
+         }, 'counters': {
+           'storage_server.writev': 309,
+           'storage_server.bytes_added': 197836146,
+           'storage_server.close': 326,
+           'storage_server.readv': 14299,
+           'storage_server.allocate': 406,
+           'storage_server.read': 170,
+           'storage_server.write': 3775,
+           'storage_server.get': 472}
+         }
         return stats
 
 class OpenMetrics(unittest.TestCase):
@@ -25,5 +113,3 @@ class OpenMetrics(unittest.TestCase):
         # The parser throws if it can't parse.
         # Wrap in a list() to drain the generator.
         families = list(parser.text_string_to_metric_families(metrics))
-        # TODO add more realistic stats, incl. missing (None) values
-