From 62cb883ca21c78ed5b3a800817be448a6fc4a5e7 Mon Sep 17 00:00:00 2001 From: Jean-Paul Calderone Date: Mon, 11 Mar 2019 12:01:20 -0400 Subject: [PATCH] Just iterate over the dictionary. It is not shared with anyone. It is not mutated inside the loop. We can use the no-copy dict iterator. --- src/allmydata/frontends/magic_folder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/allmydata/frontends/magic_folder.py b/src/allmydata/frontends/magic_folder.py index 0169ec4cd..6af494d8e 100644 --- a/src/allmydata/frontends/magic_folder.py +++ b/src/allmydata/frontends/magic_folder.py @@ -1797,7 +1797,7 @@ class Downloader(QueueMixin, WriteFileMixin): def scan_collective(result): COLLECTIVE_SCAN.log(dmds=result) list_of_deferreds = [] - for dir_name in result.keys(): + for dir_name in result: # XXX make sure it's a directory d = DeferredContext(defer.succeed(None)) d.addCallback(lambda x, dir_name=dir_name: result[dir_name][0].get_child_and_metadata(filename))