immutable: whoops, it actually takes up to 39 reads sometimes to download a corrupted file

This commit is contained in:
Zooko O'Whielacronx 2009-01-02 17:43:02 -07:00
parent e26cec2502
commit 5a21638853

View File

@ -441,11 +441,11 @@ class Test(ShareManglingMixin, unittest.TestCase):
def _after_attempt(unused=None): def _after_attempt(unused=None):
after_download_reads = self._count_reads() after_download_reads = self._count_reads()
# To pass this test, you are required to give up before reading all of the share # To pass this test, you are required to give up before reading all of the share
# data. Actually, we could give up sooner than 37 reads, but currently our download # data. Actually, we could give up sooner than 39 reads, but currently our download
# code does 37 reads. This test then serves as a "performance regression detector" # code does 39 reads. This test then serves as a "performance regression detector"
# -- if you change download code so that it takes *more* reads, then this test will # -- if you change download code so that it takes *more* reads, then this test will
# fail. # fail.
self.failIf(after_download_reads-before_download_reads > 37, (after_download_reads, before_download_reads)) self.failIf(after_download_reads-before_download_reads > 39, (after_download_reads, before_download_reads))
d.addCallback(_after_attempt) d.addCallback(_after_attempt)
return d return d