ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-02-24 02:51:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

OpenMetrics: Use list of strings instead of string concatenation

Browse Source
This commit is contained in:
Florian Sesser 2021-09-15 11:03:31 +00:00
parent 88a2e7a4fb
commit 57a3c1168e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/allmydata/web/status.py
View File

@ -1556,7 +1556,7 @@ class Statistics(MultiFormatResource):
def render_OPENMETRICS(self, req): def render_OPENMETRICS(self, req):
req.setHeader("content-type", "application/openmetrics-text; version=1.0.0; charset=utf-8") req.setHeader("content-type", "application/openmetrics-text; version=1.0.0; charset=utf-8")
stats = self._provider.get_stats() stats = self._provider.get_stats()
ret = u"" ret = []
def mangle_name(name): def mangle_name(name):
return re.sub( return re.sub(
@ -1569,13 +1569,13 @@ class Statistics(MultiFormatResource):
return str(val) if val is not None else u"NaN" return str(val) if val is not None else u"NaN"
for (k, v) in sorted(stats['counters'].items()): for (k, v) in sorted(stats['counters'].items()):
ret += u"tahoe_counters_%s %s\n" % (mangle_name(k), mangle_value(v)) ret.append(u"tahoe_counters_%s %s" % (mangle_name(k), mangle_value(v)))
for (k, v) in sorted(stats['stats'].items()): for (k, v) in sorted(stats['stats'].items()):
ret += u"tahoe_stats_%s %s\n" % (mangle_name(k), mangle_value(v)) ret.append(u"tahoe_stats_%s %s" % (mangle_name(k), mangle_value(v)))
ret += u"# EOF\n" ret.append(u"# EOF")
return ret return u"\n".join(ret)
class StatisticsElement(Element): class StatisticsElement(Element):