From 54248f334ed8a7eaab0df7ffa6e5ce981e4187d5 Mon Sep 17 00:00:00 2001
From: Sajith Sasidharan <sajith@hcoop.net>
Date: Thu, 9 Jul 2020 10:01:13 -0400
Subject: [PATCH] Use WebError, not RuntimeError, to indicate error

Several problems with using RuntimeError to signal error here:

- It dumps a rather unhelpful webpage at the user.
- The exception backtrace on Tahoe console is not quite necessary here.
- It really is not a runtime error: it is just an expected failure.
- But mainly, testing for RuntimeError is harder.
---
 src/allmydata/web/status.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/allmydata/web/status.py b/src/allmydata/web/status.py
index 8214913de..0c9e1ebb1 100644
--- a/src/allmydata/web/status.py
+++ b/src/allmydata/web/status.py
@@ -25,6 +25,7 @@ from allmydata.web.common import (
     render_time,
     MultiFormatResource,
     SlotsSequenceElement,
+    WebError,
 )
 
 from allmydata.interfaces import (
@@ -1171,9 +1172,7 @@ class Status(MultiFormatResource):
         try:
             stype, count_s = path.split("-")
         except ValueError:
-            raise RuntimeError(
-                "no - in '{}'".format(path)
-            )
+            raise WebError("no '-' in '{}'".format(path))
         count = int(count_s)
         if stype == "up":
             for s in itertools.chain(h.list_all_upload_statuses(),