ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-02-21 18:06:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Short circuit GET on ETags match

Browse Source 
When client does a conditional GET/HEAD with If-none-match:, if the condition
fails (ie, the client's ETag matches the file's) then we can short-circuit
the whole process and immediately return an empty body.
This commit is contained in:
Jeremy Fitzhardinge 2012-05-12 20:42:52 -07:00 committed by Brian Warner
parent 518ef25bdb
commit 4f1bc1b387
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/allmydata/web/filenode.py
View File

@ -415,12 +415,12 @@ class FileDownloader(rend.Page):
contentsize = filesize contentsize = filesize
req.setHeader("accept-ranges", "bytes") req.setHeader("accept-ranges", "bytes")
if not self.filenode.is_mutable(): if not self.filenode.is_mutable():
# TODO: look more closely at Request.setETag and how it interacts # if the client already has the ETag then we can short-circuit
# with a conditional "if-etag-equals" request, I think this may # the whole process.
# need to occur after the setResponseCode below
si = self.filenode.get_storage_index() si = self.filenode.get_storage_index()
if si: if si and req.setETag(base32.b2a(si)):
req.setETag(base32.b2a(si)) return ""
# TODO: for mutable files, use the roothash. For LIT, hash the data. # TODO: for mutable files, use the roothash. For LIT, hash the data.
# or maybe just use the URI for CHK and LIT. # or maybe just use the URI for CHK and LIT.
rangeheader = req.getHeader('range') rangeheader = req.getHeader('range')