From 4d4649f5c24ff89f1b538a09740eaffefea80dd2 Mon Sep 17 00:00:00 2001 From: Itamar Turner-Trauring Date: Mon, 10 Apr 2023 11:28:26 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Jean-Paul Calderone --- src/allmydata/storage/http_client.py | 2 +- src/allmydata/storage/http_server.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/allmydata/storage/http_client.py b/src/allmydata/storage/http_client.py index bd9e3fc39..ea142ed85 100644 --- a/src/allmydata/storage/http_client.py +++ b/src/allmydata/storage/http_client.py @@ -368,7 +368,7 @@ class StorageClient(object): message_to_serialize: object = None, timeout: float = 60, **kwargs, - ) -> Deferred[IResponse]: + ) -> IResponse: """ Like ``treq.request()``, but with optional secrets that get translated into corresponding HTTP headers. diff --git a/src/allmydata/storage/http_server.py b/src/allmydata/storage/http_server.py index 5ccb43c60..8647274f8 100644 --- a/src/allmydata/storage/http_server.py +++ b/src/allmydata/storage/http_server.py @@ -107,7 +107,7 @@ def _authorization_decorator(required_secrets): @wraps(f) def route(self, request, *args, **kwargs): with start_action( - action_type="allmydata:storage:http-server:handle_request", + action_type="allmydata:storage:http-server:handle-request", method=request.method, path=request.path, ) as ctx: