From 3c3ebc368a7382cd5b5fbeca0854953a62a49006 Mon Sep 17 00:00:00 2001
From: Jean-Paul Calderone <exarkun@twistedmatrix.com>
Date: Fri, 28 Jun 2019 14:27:03 -0400
Subject: [PATCH] note about some logging we should do

---
 src/allmydata/storage_client.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/allmydata/storage_client.py b/src/allmydata/storage_client.py
index 994a56060..8f1efa14f 100644
--- a/src/allmydata/storage_client.py
+++ b/src/allmydata/storage_client.py
@@ -159,6 +159,12 @@ class StorageFarmBroker(service.MultiService):
             try:
                 storage_server = self._make_storage_server(server_id, server)
             except Exception:
+                # TODO: The _make_storage_server failure is logged but maybe
+                # we should write a traceback here.  Notably, tests don't
+                # automatically fail just because we hit this case.  Well
+                # written tests will still fail if a surprising exception
+                # arrives here but they might be harder to debug without this
+                # information.
                 pass
             else:
                 self._static_server_ids.add(server_id)