ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2024-12-30 09:48:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mutable: verify incoming share signatures during Publish, it's not that expensive and it's a good idea

Browse Source
This commit is contained in:
Brian Warner 2007-11-08 14:02:36 -07:00
parent a4606d6560
commit 30a91c84c8
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/allmydata/mutable.py
View File

@ -745,11 +745,13 @@ class Publish:
(seqnum, root_hash, IV, k, N, segsize, datalen,
pubkey_s, signature, prefix) = r
# TODO: consider verifying the signature here. It's expensive.
# What can an attacker (in this case the server) accomplish? They
# could make us think that there's a newer version of the file
# out there, which would cause us to throw
# UncoordinatedWriteError (i.e. it's a DoS attack).
# self._pubkey is present because we require read-before-replace
valid = self._pubkey.verify(prefix, signature)
if not valid:
self.log("WEIRD: bad signature from %s shnum %d" %
(shnum, idlib.shortnodeid_b2a(peerid)))
continue
share = (shnum, seqnum, root_hash)
current_share_peers.add(shnum, (peerid, seqnum, root_hash) )