When callRemoteOnly as removed, these probably should've been changed to return

a Deferred.
This commit is contained in:
Itamar Turner-Trauring 2021-10-14 12:51:24 -04:00
parent 984b4ac45e
commit 22aab98fcf
3 changed files with 3 additions and 3 deletions

View File

@ -475,7 +475,7 @@ class Share(object):
# there was corruption somewhere in the given range # there was corruption somewhere in the given range
reason = "corruption in share[%d-%d): %s" % (start, start+offset, reason = "corruption in share[%d-%d): %s" % (start, start+offset,
str(f.value)) str(f.value))
self._rref.callRemote( return self._rref.callRemote(
"advise_corrupt_share", reason.encode("utf-8") "advise_corrupt_share", reason.encode("utf-8")
).addErrback(log.err, "Error from remote call to advise_corrupt_share") ).addErrback(log.err, "Error from remote call to advise_corrupt_share")

View File

@ -254,7 +254,7 @@ class WriteBucketProxy(object):
return d return d
def abort(self): def abort(self):
self._rref.callRemote("abort").addErrback(log.err, "Error from remote call to abort an immutable write bucket") return self._rref.callRemote("abort").addErrback(log.err, "Error from remote call to abort an immutable write bucket")
def get_servername(self): def get_servername(self):
return self._server.get_name() return self._server.get_name()

View File

@ -1017,7 +1017,7 @@ class _StorageServer(object):
shnum, shnum,
reason, reason,
): ):
self._rref.callRemote( return self._rref.callRemote(
"advise_corrupt_share", "advise_corrupt_share",
share_type, share_type,
storage_index, storage_index,