ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-04-07 10:56:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #514 from LeastAuthority/2873.remove-obsolete-pycrypto-dep

Browse Source 
Remove the obsolete PyCrypto dependency

PyCrypto was declared as a transitive dependency to satisfy Twisted for the purposes of SFTP.  Twisted has since moved to `cryptography` instead.  There is no reason to make Tahoe-LAFS continue to depend on PyCrypto and removing this dependency noticably reduces the dependency complexity of Tahoe-LAFS.
This commit is contained in:
Jean-Paul Calderone 2018-07-25 11:38:21 -04:00 committed by GitHub
commit 1c24c643ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS.rst
View File

@ -191,6 +191,7 @@ improvements which shouldn't have any user-visible effects:
* `PR410`_ explicit python2.7 virtualenv
* `PR419`_ fix list of supported OSes
* `PR423`_ switch travis to a supported Ubuntu
* deps: no longer declare a PyCrypto dependency (actual use vanished long ago) `PR514`_
@ -240,6 +241,7 @@ improvements which shouldn't have any user-visible effects:
.. _PR482: https://github.com/tahoe-lafs/tahoe-lafs/pull/482
.. _PR502: https://github.com/tahoe-lafs/tahoe-lafs/pull/502
.. _PR506: https://github.com/tahoe-lafs/tahoe-lafs/pull/506
.. _PR514: https://github.com/tahoe-lafs/tahoe-lafs/pull/514
.. _AnBuKu: https://github.com/AnBuKu
.. _ValdikSS: https://github.com/ValdikSS
.. _bookchin: https://github.com/bookchin

7
src/allmydata/_auto_deps.py
View File

@ -42,11 +42,6 @@ install_requires = [
# * foolscap >= 0.12.6 has an i2p.sam_endpoint() that takes kwargs
"foolscap >= 0.12.6",
# Needed for SFTP.
# pycrypto 2.2 doesn't work due to <https://bugs.launchpad.net/pycrypto/+bug/620253>
# pycrypto 2.4 doesn't work due to <https://bugs.launchpad.net/pycrypto/+bug/881130>
"pycrypto >= 2.1.0, != 2.2, != 2.4",
# pycryptopp-0.6.0 includes ed25519
"pycryptopp >= 0.6.0",
@ -112,7 +107,6 @@ package_imports = [
('platform', None),
('pyOpenSSL', 'OpenSSL'),
('OpenSSL', None),
('pycrypto', 'Crypto'),
('pyasn1', 'pyasn1'),
('service-identity', 'service_identity'),
('characteristic', 'characteristic'),
@ -176,5 +170,4 @@ warning_imports = [
'nevow',
'twisted.persisted.sob',
'twisted.python.filepath',
'Crypto.Hash.SHA',
]