From 1549e7eb18600832a3a7699f7fdbf9e975133f4b Mon Sep 17 00:00:00 2001
From: meejah <meejah@meejah.ca>
Date: Wed, 6 May 2020 15:15:19 -0600
Subject: [PATCH] simplify (for line in f.readlines() -> for line in f)

---
 src/allmydata/blacklist.py      | 2 +-
 src/allmydata/control.py        | 2 +-
 src/allmydata/frontends/auth.py | 2 +-
 src/allmydata/scripts/common.py | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/allmydata/blacklist.py b/src/allmydata/blacklist.py
index af1d185d0..89ee81a96 100644
--- a/src/allmydata/blacklist.py
+++ b/src/allmydata/blacklist.py
@@ -35,7 +35,7 @@ class Blacklist(object):
             if self.last_mtime is None or current_mtime > self.last_mtime:
                 self.entries.clear()
                 with open(self.blacklist_fn, "r") as f:
-                    for line in f.readlines():
+                    for line in f:
                         line = line.strip()
                         if not line or line.startswith("#"):
                             continue
diff --git a/src/allmydata/control.py b/src/allmydata/control.py
index 55f6db4f9..b4603b2ac 100644
--- a/src/allmydata/control.py
+++ b/src/allmydata/control.py
@@ -20,7 +20,7 @@ def get_memory_usage():
     stats = {}
     try:
         with open("/proc/self/status", "r") as f:
-            for line in f.readlines():
+            for line in f:
                 name, right = line.split(":",2)
                 if name in stat_names:
                     assert right.endswith(" kB\n")
diff --git a/src/allmydata/frontends/auth.py b/src/allmydata/frontends/auth.py
index ab56bf94d..1bd481321 100644
--- a/src/allmydata/frontends/auth.py
+++ b/src/allmydata/frontends/auth.py
@@ -32,7 +32,7 @@ class AccountFileChecker(object):
         self.pubkeys = {}
         self.rootcaps = {}
         with open(abspath_expanduser_unicode(accountfile), "r") as f:
-            for line in f.readlines():
+            for line in f:
                 line = line.strip()
                 if line.startswith("#") or not line:
                     continue
diff --git a/src/allmydata/scripts/common.py b/src/allmydata/scripts/common.py
index 89c1f94d1..91a3882fb 100644
--- a/src/allmydata/scripts/common.py
+++ b/src/allmydata/scripts/common.py
@@ -139,7 +139,7 @@ def get_aliases(nodedir):
         pass
     try:
         with codecs.open(aliasfile, "r", "utf-8") as f:
-            for line in f.readlines():
+            for line in f:
                 line = line.strip()
                 if line.startswith("#") or not line:
                     continue