ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-02-01 00:45:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

immutable: fix bug in which preexisting_shares and merged were shallowly referencing the same sets

Browse Source 
This bug had the effect of making uploads sometimes (rarely) appear to succeed when they had actually not distributed the shares well enough to achieve the desired servers-of-happiness level.
This commit is contained in:
Zooko O'Whielacronx 2010-07-19 00:54:26 -07:00
parent 461f946457
commit 13b5e44fbc
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/allmydata/util/happinessutil.py
View File

@ -3,6 +3,8 @@ I contain utilities useful for calculating servers_of_happiness, and for
reporting it in messages
"""
from copy import deepcopy
def failure_message(peer_count, k, happy, effective_happy):
# If peer_count < needed_shares, this error message makes more
# sense than any of the others, so use it.
@ -60,16 +62,16 @@ def merge_peers(servermap, used_peers=None):
argument to include the shareid -> peerid mappings implied in the
set of PeerTrackers, returning the resulting dict.
"""
# Since we mutate servermap, and are called outside of a
# context where it is okay to do that, make a copy of servermap and
# work with it.
servermap = deepcopy(servermap)
if not used_peers:
return servermap
assert(isinstance(servermap, dict))
assert(isinstance(used_peers, set))
# Since we mutate servermap, and are called outside of a
# context where it is okay to do that, make a copy of servermap and
# work with it.
servermap = servermap.copy()
for peer in used_peers:
for shnum in peer.buckets:
servermap.setdefault(shnum, set()).add(peer.peerid)