ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2024-12-20 21:43:09 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Only consider classes defined in the module we're looking at.

Browse Source 
Classes can lie about their __module__, of course, but I hope none of Tahoe's
do.
This commit is contained in:
Jean-Paul Calderone 2019-08-13 15:32:09 -04:00
parent b1c7556239
commit 132cc4605d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/allmydata/test/test_python2_regressions.py
View File

@ -15,6 +15,9 @@ def is_classic_class(obj):
# not a class. So ... less than completely useful. # not a class. So ... less than completely useful.
return type(obj) is ClassType return type(obj) is ClassType
def defined_here(obj, where):
return obj.__module__ == where
class PythonTwoRegressions(unittest.TestCase): class PythonTwoRegressions(unittest.TestCase):
""" """
A test class to hold Python2 regression tests. A test class to hold Python2 regression tests.
@ -29,6 +32,6 @@ class PythonTwoRegressions(unittest.TestCase):
for attr in mod.iterAttributes(): for attr in mod.iterAttributes():
value = attr.load() value = attr.load()
self.assertFalse( self.assertFalse(
is_classic_class(value), is_classic_class(value) and defined_here(value, mod.name),
"{} appears to be a classic class".format(attr.name), "{} appears to be a classic class".format(attr.name),
) )