mirror of
https://github.com/servalproject/serval-dna.git
synced 2025-02-03 01:30:39 +00:00
2e7d19a3f7
The "rhizome direct push" command (and also sync) was not waiting for the server's HTTP response, so it was exiting before the server had finished storing the bundle, which led to a race with the subsequent "assert bundle_received_by" test. Fixed by adding the missing code to receive the HTTP response. Refactored the code used for parsing HTTP responses in rhizome_fetch.c, and used it in rhizome_direct_http.c.
When we were looking at implementing secure calls for OpenBTS it was suggested that we configure Asterisk to use SIPS/ZRTP. This would have been relatively easy to setup, however there are a few problems. Number one is that when Asterisk checks the certificates it will either validate the certificate (checking the chain of trust and so on) and then check that the common name attribute on the certificate matches the hostname of the peer, or it will do none of these checks. This code is in main/tcptls.c line 206 (in version 1.8.14.1). This is undesirable in a setup where there is limited or no infrastructure as there is not likely to be a DNS server setup, or even rigid IP assignments that would allow a static hosts file based setup. This situation would force the administrator to disable the checks completely which would allow a trivial man in the middle attack. It would be possible to modify Asterisk to have a third way where it validates the certificate and checks the chain of trust but does not look at the common name. We decided against this approach as the VOMP channel driver was written in time to avoid it.