ExternalVendorCode/serval-dna
1
0
Fork 0
mirror of https://github.com/servalproject/serval-dna.git synced 2025-02-21 09:51:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Always silently ignore incoming data once response has started

Browse Source
This commit is contained in:
Jeremy Lakeman 2018-01-08 12:24:03 +10:30
parent 60b9472472
commit afa33484ba
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
http_server.c
View File

@ -1792,19 +1792,13 @@ static void http_request_receive(struct http_request *r)
{ {
IN(); IN();
if (r->phase != RECEIVE){ if (r->phase != RECEIVE){
// just read & throw away any data // We have already decided on the response we are going to send
// (Probably because the request was invalid in some way)
// The client might be written with simple blocking I/O, send everything then receive everything
// Or be using chuncked encoding, but we don't have any way to track state correctly anymore
// So just read & throw away any data without caring about correctness *at all*
char buff[1024]; char buff[1024];
ssize_t len = http_request_read(r, buff, sizeof buff); http_request_read(r, buff, sizeof buff);
if (len <0)
RETURNVOID;
if (r->request_content_remaining!=CONTENT_LENGTH_UNKNOWN){
if ((size_t)len > r->request_content_remaining){
IDEBUG(r->debug, "Buffer size reached, reporting overflow");
http_request_simple_response(r, 431, NULL); // Request Header Fields Too Large
RETURNVOID;
}
r->request_content_remaining -= len;
}
RETURNVOID; RETURNVOID;
} }
const char *const bufend = r->buffer + sizeof r->buffer; const char *const bufend = r->buffer + sizeof r->buffer;