Use manifest 'has_id' consistently

This commit is contained in:
Andrew Bettison 2013-12-19 19:09:53 +10:30
parent d7b926c39c
commit 8a1ce7f373
2 changed files with 3 additions and 2 deletions

View File

@ -119,7 +119,7 @@ void _rhizome_manifest_set_id(struct __sourceloc __whence, rhizome_manifest *m,
{ {
const char *v = rhizome_manifest_set(m, "id", alloca_tohex_rhizome_bid_t(*bidp)); const char *v = rhizome_manifest_set(m, "id", alloca_tohex_rhizome_bid_t(*bidp));
assert(v); // TODO: remove known manifest fields from vars[] assert(v); // TODO: remove known manifest fields from vars[]
if (bidp != &m->cryptoSignPublic && cmp_rhizome_bid_t(&m->cryptoSignPublic, bidp) != 0) { if (m->has_id && bidp != &m->cryptoSignPublic && cmp_rhizome_bid_t(&m->cryptoSignPublic, bidp) != 0) {
m->cryptoSignPublic = *bidp; m->cryptoSignPublic = *bidp;
// The BID just changed, so the secret key and bundle key are no longer valid. // The BID just changed, so the secret key and bundle key are no longer valid.
if (m->haveSecret) { if (m->haveSecret) {
@ -134,6 +134,7 @@ void _rhizome_manifest_set_id(struct __sourceloc __whence, rhizome_manifest *m,
if (m->authorship == AUTHOR_AUTHENTIC) if (m->authorship == AUTHOR_AUTHENTIC)
m->authorship = AUTHOR_LOCAL; m->authorship = AUTHOR_LOCAL;
} }
m->has_id = 1;
} }
void _rhizome_manifest_set_version(struct __sourceloc __whence, rhizome_manifest *m, uint64_t version) void _rhizome_manifest_set_version(struct __sourceloc __whence, rhizome_manifest *m, uint64_t version)

View File

@ -300,7 +300,7 @@ int rhizome_apply_bundle_secret(rhizome_manifest *m, const rhizome_bk_t *bsk)
DEBUGF("manifest[%d] bsk=%s", m->manifest_record_number, bsk ? alloca_tohex_rhizome_bk_t(*bsk) : "NULL"); DEBUGF("manifest[%d] bsk=%s", m->manifest_record_number, bsk ? alloca_tohex_rhizome_bk_t(*bsk) : "NULL");
assert(m->haveSecret == SECRET_UNKNOWN); assert(m->haveSecret == SECRET_UNKNOWN);
assert(is_all_matching(m->cryptoSignSecret, sizeof m->cryptoSignSecret, 0)); assert(is_all_matching(m->cryptoSignSecret, sizeof m->cryptoSignSecret, 0));
assert(!rhizome_bid_t_is_zero(m->cryptoSignPublic)); assert(m->has_id);
assert(bsk != NULL); assert(bsk != NULL);
assert(!rhizome_is_bk_none(bsk)); assert(!rhizome_is_bk_none(bsk));
if (rhizome_verify_bundle_privatekey(bsk->binary, m->cryptoSignPublic.binary)) { if (rhizome_verify_bundle_privatekey(bsk->binary, m->cryptoSignPublic.binary)) {