ExternalVendorCode/serval-dna
1
0
Fork 0
mirror of https://github.com/servalproject/serval-dna.git synced 2025-02-20 17:33:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix Rom's socket cleanup-on-start code

Browse Source 
Fix buffer overflow bug: replace call to sprintf(3) with call to
FORM_SERVAL_INSTANCE_PATH()

Fix file descriptor leak bug: add missing closedir(3) call

Use lstat() instead of stat() to avoid warnings on broken sym links

Use WARNF_perror() where appropriate in preference to WARNF()

Remove redundant one-line comments
This commit is contained in:
Andrew Bettison 2013-09-19 04:14:41 +09:30
parent d64d9487c1
commit 5c84b2ffd5
1 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
overlay_mdp.c
View File

@ -39,34 +39,25 @@ static int overlay_saw_mdp_frame(struct overlay_frame *frame, overlay_mdp_frame
static void overlay_mdp_clean_socket_files()
{
const char *instance_path = serval_instancepath();
char path[PATH_MAX];
DIR *dir;
struct dirent *dp;
struct stat st;
/* Open instance_path directory. */
if ((dir = opendir(instance_path)) == NULL) {
WARNF("Can't open %s\n", instance_path);
WARNF_perror("opendir(%s)", alloca_str_toprint(instance_path));
return;
}
/* Read all files in instance_path directory. */
while ((dp = readdir(dir)) != NULL) {
/* Concatenate dir and name. */
sprintf(path, "%s/%s", instance_path, dp->d_name);
/* Retrieve stat info. */
if (stat(path, &st)) {
WARNF("Cannot stat %s (errno=%d)\n", path, errno);
char path[PATH_MAX];
if (!FORM_SERVAL_INSTANCE_PATH(path, dp->d_name))
continue;
struct stat st;
if (lstat(path, &st)) {
WARNF_perror("stat(%s)", alloca_str_toprint(path));
continue;
}
if (S_ISSOCK(st.st_mode)) {
/* The file is a UNIX socket, delete it. */
if (S_ISSOCK(st.st_mode))
unlink(path);
}
}
closedir(dir);
}
int overlay_mdp_setup_sockets()