ExternalVendorCode/serval-dna
1
0
Fork 0
mirror of https://github.com/servalproject/serval-dna.git synced 2025-03-11 06:53:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix some dodgy code and remove the #warning message pointing to it

Browse Source
This commit is contained in:
Andrew Bettison 2012-03-26 15:03:57 +10:30
parent 84b24b9918
commit 4e29cb1eb3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server.c
View File

@ -416,9 +416,8 @@ int processRequest(unsigned char *packet,int len,
if (var_id&0x80) instance=packet[++pofs]; if (var_id&0x80) instance=packet[++pofs];
pofs++; pofs++;
int offset=(packet[pofs]<<8)+packet[pofs+1]; pofs+=2; int offset=(packet[pofs]<<8)+packet[pofs+1]; pofs+=2;
#warning Defining SID here is masking the version passed in, which other stuff still expects to be visible? Also, does it need to be SID_STRLEN*2+1 to allow for byte->hex expansion? Or has SID_STRLEN been defined to take that into account?
char sid[SID_STRLEN+1];
char *hlr_sid=NULL; char *hlr_sid=NULL;
char hlr_sid_s[SID_STRLEN+1];
pofs+=2; pofs+=2;
@ -469,7 +468,7 @@ int processRequest(unsigned char *packet,int len,
if (packageVariableSegment(data,&dlen,h,offset,MAX_DATA_BYTES+16)) if (packageVariableSegment(data,&dlen,h,offset,MAX_DATA_BYTES+16))
return setReason("packageVariableSegment() failed."); return setReason("packageVariableSegment() failed.");
hlr_sid = hlrSid(hlr, ofs, sid); hlr_sid = hlrSid(hlr, ofs, hlr_sid_s);
sendDone++; sendDone++;
} }