mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-28 01:28:59 +00:00
84d0b0b925
Removed because they are upstream: generic/backport-5.15/741-v6.9-01-netfilter-flowtable-validate-pppoe-header.patch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.15.y&id=d06977b9a4109f8738bb276125eb6a0b772bc433 Removed because they are upstream: generic/backport-5.15/741-v6.9-02-netfilter-flowtable-incorrect-pppoe-tuple.patch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.15.y&id=e719b52d0c56989b0f3475a03a6d64f182c85b56 Manual adapted the following patches: generic/pending-5.15/700-netfilter-nft_flow_offload-handle-netdevice-events-f.patch generic/pending-5.15/723-net-mt7531-ensure-all-MACs-are-powered-down-before-r.patch Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
274 lines
7.0 KiB
Diff
274 lines
7.0 KiB
Diff
From 1557c679f71c82a994eae0baadbaeb62b71e15bf Mon Sep 17 00:00:00 2001
|
|
From: Daniel Golle <daniel@makrotopia.org>
|
|
Date: Mon, 3 Apr 2023 02:18:16 +0100
|
|
Subject: [PATCH 09/16] net: dsa: mt7530: introduce mutex helpers
|
|
|
|
As the MDIO bus lock only needs to be involved if actually operating
|
|
on an MDIO-connected switch we will need to skip locking for built-in
|
|
switches which are accessed via MMIO.
|
|
Create helper functions which simplify that upcoming change.
|
|
|
|
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
|
|
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/dsa/mt7530.c | 73 ++++++++++++++++++++--------------------
|
|
1 file changed, 36 insertions(+), 37 deletions(-)
|
|
|
|
--- a/drivers/net/dsa/mt7530.c
|
|
+++ b/drivers/net/dsa/mt7530.c
|
|
@@ -144,31 +144,40 @@ err:
|
|
}
|
|
|
|
static void
|
|
-core_write(struct mt7530_priv *priv, u32 reg, u32 val)
|
|
+mt7530_mutex_lock(struct mt7530_priv *priv)
|
|
{
|
|
- struct mii_bus *bus = priv->bus;
|
|
+ mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+}
|
|
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+static void
|
|
+mt7530_mutex_unlock(struct mt7530_priv *priv)
|
|
+{
|
|
+ mutex_unlock(&priv->bus->mdio_lock);
|
|
+}
|
|
+
|
|
+static void
|
|
+core_write(struct mt7530_priv *priv, u32 reg, u32 val)
|
|
+{
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
core_write_mmd_indirect(priv, reg, MDIO_MMD_VEND2, val);
|
|
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
}
|
|
|
|
static void
|
|
core_rmw(struct mt7530_priv *priv, u32 reg, u32 mask, u32 set)
|
|
{
|
|
- struct mii_bus *bus = priv->bus;
|
|
u32 val;
|
|
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
val = core_read_mmd_indirect(priv, reg, MDIO_MMD_VEND2);
|
|
val &= ~mask;
|
|
val |= set;
|
|
core_write_mmd_indirect(priv, reg, MDIO_MMD_VEND2, val);
|
|
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
}
|
|
|
|
static void
|
|
@@ -265,13 +274,11 @@ mt7530_mii_read(struct mt7530_priv *priv
|
|
static void
|
|
mt7530_write(struct mt7530_priv *priv, u32 reg, u32 val)
|
|
{
|
|
- struct mii_bus *bus = priv->bus;
|
|
-
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
mt7530_mii_write(priv, reg, val);
|
|
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
}
|
|
|
|
static u32
|
|
@@ -283,14 +290,13 @@ _mt7530_unlocked_read(struct mt7530_dumm
|
|
static u32
|
|
_mt7530_read(struct mt7530_dummy_poll *p)
|
|
{
|
|
- struct mii_bus *bus = p->priv->bus;
|
|
u32 val;
|
|
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(p->priv);
|
|
|
|
val = mt7530_mii_read(p->priv, p->reg);
|
|
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(p->priv);
|
|
|
|
return val;
|
|
}
|
|
@@ -308,13 +314,11 @@ static void
|
|
mt7530_rmw(struct mt7530_priv *priv, u32 reg,
|
|
u32 mask, u32 set)
|
|
{
|
|
- struct mii_bus *bus = priv->bus;
|
|
-
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
regmap_update_bits(priv->regmap, reg, mask, set);
|
|
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
}
|
|
|
|
static void
|
|
@@ -660,14 +664,13 @@ static int
|
|
mt7531_ind_c45_phy_read(struct mt7530_priv *priv, int port, int devad,
|
|
int regnum)
|
|
{
|
|
- struct mii_bus *bus = priv->bus;
|
|
struct mt7530_dummy_poll p;
|
|
u32 reg, val;
|
|
int ret;
|
|
|
|
INIT_MT7530_DUMMY_POLL(&p, priv, MT7531_PHY_IAC);
|
|
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
ret = readx_poll_timeout(_mt7530_unlocked_read, &p, val,
|
|
!(val & MT7531_PHY_ACS_ST), 20, 100000);
|
|
@@ -700,7 +703,7 @@ mt7531_ind_c45_phy_read(struct mt7530_pr
|
|
|
|
ret = val & MT7531_MDIO_RW_DATA_MASK;
|
|
out:
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
|
|
return ret;
|
|
}
|
|
@@ -709,14 +712,13 @@ static int
|
|
mt7531_ind_c45_phy_write(struct mt7530_priv *priv, int port, int devad,
|
|
int regnum, u32 data)
|
|
{
|
|
- struct mii_bus *bus = priv->bus;
|
|
struct mt7530_dummy_poll p;
|
|
u32 val, reg;
|
|
int ret;
|
|
|
|
INIT_MT7530_DUMMY_POLL(&p, priv, MT7531_PHY_IAC);
|
|
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
ret = readx_poll_timeout(_mt7530_unlocked_read, &p, val,
|
|
!(val & MT7531_PHY_ACS_ST), 20, 100000);
|
|
@@ -748,7 +750,7 @@ mt7531_ind_c45_phy_write(struct mt7530_p
|
|
}
|
|
|
|
out:
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
|
|
return ret;
|
|
}
|
|
@@ -756,14 +758,13 @@ out:
|
|
static int
|
|
mt7531_ind_c22_phy_read(struct mt7530_priv *priv, int port, int regnum)
|
|
{
|
|
- struct mii_bus *bus = priv->bus;
|
|
struct mt7530_dummy_poll p;
|
|
int ret;
|
|
u32 val;
|
|
|
|
INIT_MT7530_DUMMY_POLL(&p, priv, MT7531_PHY_IAC);
|
|
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
ret = readx_poll_timeout(_mt7530_unlocked_read, &p, val,
|
|
!(val & MT7531_PHY_ACS_ST), 20, 100000);
|
|
@@ -786,7 +787,7 @@ mt7531_ind_c22_phy_read(struct mt7530_pr
|
|
|
|
ret = val & MT7531_MDIO_RW_DATA_MASK;
|
|
out:
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
|
|
return ret;
|
|
}
|
|
@@ -795,14 +796,13 @@ static int
|
|
mt7531_ind_c22_phy_write(struct mt7530_priv *priv, int port, int regnum,
|
|
u16 data)
|
|
{
|
|
- struct mii_bus *bus = priv->bus;
|
|
struct mt7530_dummy_poll p;
|
|
int ret;
|
|
u32 reg;
|
|
|
|
INIT_MT7530_DUMMY_POLL(&p, priv, MT7531_PHY_IAC);
|
|
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
ret = readx_poll_timeout(_mt7530_unlocked_read, &p, reg,
|
|
!(reg & MT7531_PHY_ACS_ST), 20, 100000);
|
|
@@ -824,7 +824,7 @@ mt7531_ind_c22_phy_write(struct mt7530_p
|
|
}
|
|
|
|
out:
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
|
|
return ret;
|
|
}
|
|
@@ -1344,7 +1344,6 @@ static int
|
|
mt7530_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
|
|
{
|
|
struct mt7530_priv *priv = ds->priv;
|
|
- struct mii_bus *bus = priv->bus;
|
|
int length;
|
|
u32 val;
|
|
|
|
@@ -1355,7 +1354,7 @@ mt7530_port_change_mtu(struct dsa_switch
|
|
if (!dsa_is_cpu_port(ds, port))
|
|
return 0;
|
|
|
|
- mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
|
|
val = mt7530_mii_read(priv, MT7530_GMACCR);
|
|
val &= ~MAX_RX_PKT_LEN_MASK;
|
|
@@ -1376,7 +1375,7 @@ mt7530_port_change_mtu(struct dsa_switch
|
|
|
|
mt7530_mii_write(priv, MT7530_GMACCR, val);
|
|
|
|
- mutex_unlock(&bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
|
|
return 0;
|
|
}
|
|
@@ -2172,10 +2171,10 @@ mt7530_irq_thread_fn(int irq, void *dev_
|
|
u32 val;
|
|
int p;
|
|
|
|
- mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
val = mt7530_mii_read(priv, MT7530_SYS_INT_STS);
|
|
mt7530_mii_write(priv, MT7530_SYS_INT_STS, val);
|
|
- mutex_unlock(&priv->bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
|
|
for (p = 0; p < MT7530_NUM_PHYS; p++) {
|
|
if (BIT(p) & val) {
|
|
@@ -2211,7 +2210,7 @@ mt7530_irq_bus_lock(struct irq_data *d)
|
|
{
|
|
struct mt7530_priv *priv = irq_data_get_irq_chip_data(d);
|
|
|
|
- mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED);
|
|
+ mt7530_mutex_lock(priv);
|
|
}
|
|
|
|
static void
|
|
@@ -2220,7 +2219,7 @@ mt7530_irq_bus_sync_unlock(struct irq_da
|
|
struct mt7530_priv *priv = irq_data_get_irq_chip_data(d);
|
|
|
|
mt7530_mii_write(priv, MT7530_SYS_INT_EN, priv->irq_enable);
|
|
- mutex_unlock(&priv->bus->mdio_lock);
|
|
+ mt7530_mutex_unlock(priv);
|
|
}
|
|
|
|
static struct irq_chip mt7530_irq_chip = {
|