mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-22 15:02:32 +00:00
76 lines
2.6 KiB
Diff
76 lines
2.6 KiB
Diff
From 7b778ae4eb9cd6e1518e4e47902a104b13ae8929 Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
|
Date: Thu, 11 Feb 2021 13:12:36 +0100
|
|
Subject: [PATCH] net: broadcom: bcm4908_enet: drop "inline" from C functions
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
It seems preferred to let compiler optimize code if applicable.
|
|
While at it drop unused enet_umac_maskset().
|
|
|
|
Suggested-by: Andrew Lunn <andrew@lunn.ch>
|
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
|
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
|
|
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/ethernet/broadcom/bcm4908_enet.c | 19 +++++++------------
|
|
1 file changed, 7 insertions(+), 12 deletions(-)
|
|
|
|
--- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
|
|
+++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
|
|
@@ -75,17 +75,17 @@ struct bcm4908_enet {
|
|
* R/W ops
|
|
*/
|
|
|
|
-static inline u32 enet_read(struct bcm4908_enet *enet, u16 offset)
|
|
+static u32 enet_read(struct bcm4908_enet *enet, u16 offset)
|
|
{
|
|
return readl(enet->base + offset);
|
|
}
|
|
|
|
-static inline void enet_write(struct bcm4908_enet *enet, u16 offset, u32 value)
|
|
+static void enet_write(struct bcm4908_enet *enet, u16 offset, u32 value)
|
|
{
|
|
writel(value, enet->base + offset);
|
|
}
|
|
|
|
-static inline void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set)
|
|
+static void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set)
|
|
{
|
|
u32 val;
|
|
|
|
@@ -96,27 +96,22 @@ static inline void enet_maskset(struct b
|
|
enet_write(enet, offset, val);
|
|
}
|
|
|
|
-static inline void enet_set(struct bcm4908_enet *enet, u16 offset, u32 set)
|
|
+static void enet_set(struct bcm4908_enet *enet, u16 offset, u32 set)
|
|
{
|
|
enet_maskset(enet, offset, set, set);
|
|
}
|
|
|
|
-static inline u32 enet_umac_read(struct bcm4908_enet *enet, u16 offset)
|
|
+static u32 enet_umac_read(struct bcm4908_enet *enet, u16 offset)
|
|
{
|
|
return enet_read(enet, ENET_UNIMAC + offset);
|
|
}
|
|
|
|
-static inline void enet_umac_write(struct bcm4908_enet *enet, u16 offset, u32 value)
|
|
+static void enet_umac_write(struct bcm4908_enet *enet, u16 offset, u32 value)
|
|
{
|
|
enet_write(enet, ENET_UNIMAC + offset, value);
|
|
}
|
|
|
|
-static inline void enet_umac_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set)
|
|
-{
|
|
- enet_maskset(enet, ENET_UNIMAC + offset, mask, set);
|
|
-}
|
|
-
|
|
-static inline void enet_umac_set(struct bcm4908_enet *enet, u16 offset, u32 set)
|
|
+static void enet_umac_set(struct bcm4908_enet *enet, u16 offset, u32 set)
|
|
{
|
|
enet_set(enet, ENET_UNIMAC + offset, set);
|
|
}
|