mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-29 10:08:59 +00:00
8a9733ee0d
gcc 10 with -O2 reports following:
In function ‘strncpy’,
inlined from ‘rpc_sys_packagelist’ at /opt/devel/openwrt/c-projects/rpcd/sys.c:244:4:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 128 equals destination size [-Werror=stringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘strncpy’,
inlined from ‘rpc_sys_packagelist’ at /opt/devel/openwrt/c-projects/rpcd/sys.c:227:4:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 128 equals destination size [-Werror=stringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Since it is not possible to avoid truncation by strncpy, it is necessary
to make sure the result of strncpy is properly NUL-terminated and the
NUL must be inserted explicitly, after strncpy has returned.
References: #10442
Reported-by: Alexey Smirnov <s.alexey@gmail.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
(cherry picked from commit 34ddd2e545)
106 lines
2.8 KiB
Makefile
106 lines
2.8 KiB
Makefile
#
|
|
# Copyright (C) 2013-2016 OpenWrt.org
|
|
#
|
|
# This is free software, licensed under the GNU General Public License v2.
|
|
# See /LICENSE for more information.
|
|
#
|
|
|
|
include $(TOPDIR)/rules.mk
|
|
|
|
PKG_NAME:=rpcd
|
|
PKG_RELEASE:=1
|
|
|
|
PKG_SOURCE_PROTO:=git
|
|
PKG_SOURCE_URL=$(PROJECT_GIT)/project/rpcd.git
|
|
PKG_MIRROR_HASH:=52ca9beab4b18afec9717a5f05c5232ef6160c3ece82a020851ac3aeaa52a29a
|
|
PKG_SOURCE_DATE:=2022-08-24
|
|
PKG_SOURCE_VERSION:=82904bd4f92e5928d047db6396cc14ca2b07d89f
|
|
PKG_MAINTAINER:=Jo-Philipp Wich <jo@mein.io>
|
|
|
|
PKG_LICENSE:=ISC
|
|
PKG_LICENSE_FILES:=
|
|
|
|
PKG_ASLR_PIE_REGULAR:=1
|
|
|
|
include $(INCLUDE_DIR)/package.mk
|
|
include $(INCLUDE_DIR)/cmake.mk
|
|
|
|
define Build/InstallDev
|
|
$(INSTALL_DIR) $(1)/usr/include
|
|
$(CP) $(PKG_BUILD_DIR)/include/rpcd $(1)/usr/include/
|
|
endef
|
|
|
|
define Package/rpcd/default
|
|
SECTION:=utils
|
|
CATEGORY:=Base system
|
|
TITLE:=OpenWrt ubus RPC backend server
|
|
DEPENDS:=+libubus +libubox
|
|
endef
|
|
|
|
define Package/rpcd
|
|
$(Package/rpcd/default)
|
|
DEPENDS+= +libuci +libblobmsg-json +libjson-c
|
|
endef
|
|
|
|
define Package/rpcd/description
|
|
This package provides the UBUS RPC backend server to expose various
|
|
functionality to frontend programs via JSON-RPC.
|
|
endef
|
|
|
|
define Package/rpcd/conffiles
|
|
/etc/config/rpcd
|
|
endef
|
|
|
|
TARGET_LDFLAGS += -lcrypt
|
|
|
|
define Package/rpcd/install
|
|
$(INSTALL_DIR) $(1)/etc/init.d
|
|
$(INSTALL_BIN) ./files/rpcd.init $(1)/etc/init.d/rpcd
|
|
$(INSTALL_DIR) $(1)/sbin
|
|
$(INSTALL_BIN) $(PKG_BUILD_DIR)/rpcd $(1)/sbin/rpcd
|
|
$(INSTALL_DIR) $(1)/usr/share/rpcd/acl.d
|
|
$(INSTALL_DATA) $(PKG_BUILD_DIR)/unauthenticated.json $(1)/usr/share/rpcd/acl.d/unauthenticated.json
|
|
$(INSTALL_DIR) $(1)/etc/config
|
|
$(INSTALL_CONF) ./files/rpcd.config $(1)/etc/config/rpcd
|
|
$(INSTALL_DIR) $(1)/etc/uci-defaults
|
|
$(INSTALL_BIN) ./files/50-migrate-rpcd-ubus-sock.sh $(1)/etc/uci-defaults
|
|
endef
|
|
|
|
|
|
# 1: plugin name
|
|
# 2: extra dependencies
|
|
# 3: plugin title/description
|
|
define BuildPlugin
|
|
|
|
PKG_CONFIG_DEPENDS += CONFIG_PACKAGE_rpcd-mod-$(1)
|
|
|
|
define Package/rpcd-mod-$(1)
|
|
$(Package/rpcd/default)
|
|
TITLE+= ($(1) plugin)
|
|
DEPENDS+=rpcd $(2)
|
|
endef
|
|
|
|
define Package/rpcd-mod-$(1)/description
|
|
$(3)
|
|
endef
|
|
|
|
define Package/rpcd-mod-$(1)/postinst
|
|
#!/bin/sh
|
|
[ -n "$$$${IPKG_INSTROOT}" ] || /etc/init.d/rpcd reload
|
|
endef
|
|
|
|
define Package/rpcd-mod-$(1)/install
|
|
$(INSTALL_DIR) $$(1)/usr/lib/rpcd
|
|
$(INSTALL_BIN) $(PKG_BUILD_DIR)/$(1).so $$(1)/usr/lib/rpcd/
|
|
endef
|
|
|
|
$$(eval $$(call BuildPackage,rpcd-mod-$(1)))
|
|
|
|
endef
|
|
|
|
$(eval $(call BuildPackage,rpcd))
|
|
$(eval $(call BuildPlugin,file,,Provides ubus calls for file and directory operations.))
|
|
$(eval $(call BuildPlugin,rpcsys,,Provides ubus calls for sysupgrade and password changing.))
|
|
$(eval $(call BuildPlugin,iwinfo,+libiwinfo,Provides ubus calls for accessing iwinfo data.))
|
|
$(eval $(call BuildPlugin,ucode,+libucode,Allows implementing plugins using ucode scripts.))
|