mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-22 23:12:32 +00:00
4ae2f43b3a
* fix switch ports with modes other than 1000M/Full * set 32-bit dma_coherent_mask to get PPE to work with 4 GiB of RAM * sync driver for built-in 1GE PHY with MediaTek SDK sources Signed-off-by: Daniel Golle <daniel@makrotopia.org>
271 lines
9.1 KiB
Diff
271 lines
9.1 KiB
Diff
From f2195279c234c0f618946424b8236026126bc595 Mon Sep 17 00:00:00 2001
|
|
Message-ID: <f2195279c234c0f618946424b8236026126bc595.1706071311.git.daniel@makrotopia.org>
|
|
From: Daniel Golle <daniel@makrotopia.org>
|
|
Date: Wed, 24 Jan 2024 02:27:04 +0000
|
|
Subject: [PATCH net] net: phy: mediatek-ge-soc: sync driver with MediaTek SDK
|
|
To: Daniel Golle <daniel@makrotopia.org>,
|
|
Qingfang Deng <dqfext@gmail.com>,
|
|
SkyLake Huang <SkyLake.Huang@mediatek.com>,
|
|
Andrew Lunn <andrew@lunn.ch>,
|
|
Heiner Kallweit <hkallweit1@gmail.com>,
|
|
Russell King <linux@armlinux.org.uk>,
|
|
David S. Miller <davem@davemloft.net>,
|
|
Eric Dumazet <edumazet@google.com>,
|
|
Jakub Kicinski <kuba@kernel.org>,
|
|
Paolo Abeni <pabeni@redhat.com>,
|
|
Matthias Brugger <matthias.bgg@gmail.com>,
|
|
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
|
|
netdev@vger.kernel.org,
|
|
linux-kernel@vger.kernel.org,
|
|
linux-arm-kernel@lists.infradead.org,
|
|
linux-mediatek@lists.infradead.org
|
|
|
|
Sync initialization and calibration routines with MediaTek's reference
|
|
driver. Improves compliance and resolves link stability issues with
|
|
CH340 IoT devices connected to MT798x built-in PHYs.
|
|
|
|
Fixes: 98c485eaf509 ("net: phy: add driver for MediaTek SoC built-in GE PHYs")
|
|
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
|
|
---
|
|
drivers/net/phy/mediatek-ge-soc.c | 147 ++++++++++++++++--------------
|
|
1 file changed, 81 insertions(+), 66 deletions(-)
|
|
|
|
--- a/drivers/net/phy/mediatek-ge-soc.c
|
|
+++ b/drivers/net/phy/mediatek-ge-soc.c
|
|
@@ -479,7 +479,7 @@ static int tx_r50_fill_result(struct phy
|
|
u16 reg, val;
|
|
|
|
if (phydev->drv->phy_id == MTK_GPHY_ID_MT7988)
|
|
- bias = -2;
|
|
+ bias = -1;
|
|
|
|
val = clamp_val(bias + tx_r50_cal_val, 0, 63);
|
|
|
|
@@ -695,6 +695,11 @@ restore:
|
|
static void mt798x_phy_common_finetune(struct phy_device *phydev)
|
|
{
|
|
phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
|
|
+ /* SlvDSPreadyTime = 24, MasDSPreadyTime = 24 */
|
|
+ __phy_write(phydev, 0x11, 0xc71);
|
|
+ __phy_write(phydev, 0x12, 0xc);
|
|
+ __phy_write(phydev, 0x10, 0x8fae);
|
|
+
|
|
/* EnabRandUpdTrig = 1 */
|
|
__phy_write(phydev, 0x11, 0x2f00);
|
|
__phy_write(phydev, 0x12, 0xe);
|
|
@@ -705,15 +710,56 @@ static void mt798x_phy_common_finetune(s
|
|
__phy_write(phydev, 0x12, 0x0);
|
|
__phy_write(phydev, 0x10, 0x83aa);
|
|
|
|
- /* TrFreeze = 0 */
|
|
+ /* FfeUpdGainForce = 1(Enable), FfeUpdGainForceVal = 4 */
|
|
+ __phy_write(phydev, 0x11, 0x240);
|
|
+ __phy_write(phydev, 0x12, 0x0);
|
|
+ __phy_write(phydev, 0x10, 0x9680);
|
|
+
|
|
+ /* TrFreeze = 0 (mt7988 default) */
|
|
__phy_write(phydev, 0x11, 0x0);
|
|
__phy_write(phydev, 0x12, 0x0);
|
|
__phy_write(phydev, 0x10, 0x9686);
|
|
|
|
+ /* SSTrKp100 = 5 */
|
|
+ /* SSTrKf100 = 6 */
|
|
+ /* SSTrKp1000Mas = 5 */
|
|
+ /* SSTrKf1000Mas = 6 */
|
|
/* SSTrKp1000Slv = 5 */
|
|
+ /* SSTrKf1000Slv = 6 */
|
|
__phy_write(phydev, 0x11, 0xbaef);
|
|
__phy_write(phydev, 0x12, 0x2e);
|
|
__phy_write(phydev, 0x10, 0x968c);
|
|
+ phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
|
|
+}
|
|
+
|
|
+static void mt7981_phy_finetune(struct phy_device *phydev)
|
|
+{
|
|
+ u16 val[8] = { 0x01ce, 0x01c1,
|
|
+ 0x020f, 0x0202,
|
|
+ 0x03d0, 0x03c0,
|
|
+ 0x0013, 0x0005 };
|
|
+ int i, k;
|
|
+
|
|
+ /* 100M eye finetune:
|
|
+ * Keep middle level of TX MLT3 shapper as default.
|
|
+ * Only change TX MLT3 overshoot level here.
|
|
+ */
|
|
+ for (k = 0, i = 1; i < 12; i++) {
|
|
+ if (i % 3 == 0)
|
|
+ continue;
|
|
+ phy_write_mmd(phydev, MDIO_MMD_VEND1, i, val[k++]);
|
|
+ }
|
|
+
|
|
+ phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
|
|
+ /* ResetSyncOffset = 6 */
|
|
+ __phy_write(phydev, 0x11, 0x600);
|
|
+ __phy_write(phydev, 0x12, 0x0);
|
|
+ __phy_write(phydev, 0x10, 0x8fc0);
|
|
+
|
|
+ /* VgaDecRate = 1 */
|
|
+ __phy_write(phydev, 0x11, 0x4c2a);
|
|
+ __phy_write(phydev, 0x12, 0x3e);
|
|
+ __phy_write(phydev, 0x10, 0x8fa4);
|
|
|
|
/* MrvlTrFix100Kp = 3, MrvlTrFix100Kf = 2,
|
|
* MrvlTrFix1000Kp = 3, MrvlTrFix1000Kf = 2
|
|
@@ -728,7 +774,7 @@ static void mt798x_phy_common_finetune(s
|
|
__phy_write(phydev, 0x10, 0x8ec0);
|
|
phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
|
|
|
|
- /* TR_OPEN_LOOP_EN = 1, lpf_x_average = 9*/
|
|
+ /* TR_OPEN_LOOP_EN = 1, lpf_x_average = 9 */
|
|
phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG234,
|
|
MTK_PHY_TR_OPEN_LOOP_EN_MASK | MTK_PHY_LPF_X_AVERAGE_MASK,
|
|
BIT(0) | FIELD_PREP(MTK_PHY_LPF_X_AVERAGE_MASK, 0x9));
|
|
@@ -761,48 +807,6 @@ static void mt798x_phy_common_finetune(s
|
|
phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_LDO_OUTPUT_V, 0x2222);
|
|
}
|
|
|
|
-static void mt7981_phy_finetune(struct phy_device *phydev)
|
|
-{
|
|
- u16 val[8] = { 0x01ce, 0x01c1,
|
|
- 0x020f, 0x0202,
|
|
- 0x03d0, 0x03c0,
|
|
- 0x0013, 0x0005 };
|
|
- int i, k;
|
|
-
|
|
- /* 100M eye finetune:
|
|
- * Keep middle level of TX MLT3 shapper as default.
|
|
- * Only change TX MLT3 overshoot level here.
|
|
- */
|
|
- for (k = 0, i = 1; i < 12; i++) {
|
|
- if (i % 3 == 0)
|
|
- continue;
|
|
- phy_write_mmd(phydev, MDIO_MMD_VEND1, i, val[k++]);
|
|
- }
|
|
-
|
|
- phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
|
|
- /* SlvDSPreadyTime = 24, MasDSPreadyTime = 24 */
|
|
- __phy_write(phydev, 0x11, 0xc71);
|
|
- __phy_write(phydev, 0x12, 0xc);
|
|
- __phy_write(phydev, 0x10, 0x8fae);
|
|
-
|
|
- /* ResetSyncOffset = 6 */
|
|
- __phy_write(phydev, 0x11, 0x600);
|
|
- __phy_write(phydev, 0x12, 0x0);
|
|
- __phy_write(phydev, 0x10, 0x8fc0);
|
|
-
|
|
- /* VgaDecRate = 1 */
|
|
- __phy_write(phydev, 0x11, 0x4c2a);
|
|
- __phy_write(phydev, 0x12, 0x3e);
|
|
- __phy_write(phydev, 0x10, 0x8fa4);
|
|
-
|
|
- /* FfeUpdGainForce = 4 */
|
|
- __phy_write(phydev, 0x11, 0x240);
|
|
- __phy_write(phydev, 0x12, 0x0);
|
|
- __phy_write(phydev, 0x10, 0x9680);
|
|
-
|
|
- phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
|
|
-}
|
|
-
|
|
static void mt7988_phy_finetune(struct phy_device *phydev)
|
|
{
|
|
u16 val[12] = { 0x0187, 0x01cd, 0x01c8, 0x0182,
|
|
@@ -817,17 +821,7 @@ static void mt7988_phy_finetune(struct p
|
|
/* TCT finetune */
|
|
phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_TX_FILTER, 0x5);
|
|
|
|
- /* Disable TX power saving */
|
|
- phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG7,
|
|
- MTK_PHY_DA_AD_BUF_BIAS_LP_MASK, 0x3 << 8);
|
|
-
|
|
phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
|
|
-
|
|
- /* SlvDSPreadyTime = 24, MasDSPreadyTime = 12 */
|
|
- __phy_write(phydev, 0x11, 0x671);
|
|
- __phy_write(phydev, 0x12, 0xc);
|
|
- __phy_write(phydev, 0x10, 0x8fae);
|
|
-
|
|
/* ResetSyncOffset = 5 */
|
|
__phy_write(phydev, 0x11, 0x500);
|
|
__phy_write(phydev, 0x12, 0x0);
|
|
@@ -835,13 +829,27 @@ static void mt7988_phy_finetune(struct p
|
|
|
|
/* VgaDecRate is 1 at default on mt7988 */
|
|
|
|
- phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
|
|
+ /* MrvlTrFix100Kp = 6, MrvlTrFix100Kf = 7,
|
|
+ * MrvlTrFix1000Kp = 6, MrvlTrFix1000Kf = 7
|
|
+ */
|
|
+ __phy_write(phydev, 0x11, 0xb90a);
|
|
+ __phy_write(phydev, 0x12, 0x6f);
|
|
+ __phy_write(phydev, 0x10, 0x8f82);
|
|
+
|
|
+ /* RemAckCntLimitCtrl = 1 */
|
|
+ __phy_write(phydev, 0x11, 0xfbba);
|
|
+ __phy_write(phydev, 0x12, 0xc3);
|
|
+ __phy_write(phydev, 0x10, 0x87f8);
|
|
|
|
- phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_2A30);
|
|
- /* TxClkOffset = 2 */
|
|
- __phy_modify(phydev, MTK_PHY_ANARG_RG, MTK_PHY_TCLKOFFSET_MASK,
|
|
- FIELD_PREP(MTK_PHY_TCLKOFFSET_MASK, 0x2));
|
|
phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
|
|
+
|
|
+ /* TR_OPEN_LOOP_EN = 1, lpf_x_average = 10 */
|
|
+ phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG234,
|
|
+ MTK_PHY_TR_OPEN_LOOP_EN_MASK | MTK_PHY_LPF_X_AVERAGE_MASK,
|
|
+ BIT(0) | FIELD_PREP(MTK_PHY_LPF_X_AVERAGE_MASK, 0xa));
|
|
+
|
|
+ /* rg_tr_lpf_cnt_val = 1023 */
|
|
+ phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LPF_CNT_VAL, 0x3ff);
|
|
}
|
|
|
|
static void mt798x_phy_eee(struct phy_device *phydev)
|
|
@@ -874,11 +882,11 @@ static void mt798x_phy_eee(struct phy_de
|
|
MTK_PHY_LPI_SLV_SEND_TX_EN,
|
|
FIELD_PREP(MTK_PHY_LPI_SLV_SEND_TX_TIMER_MASK, 0x120));
|
|
|
|
- phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG239,
|
|
- MTK_PHY_LPI_SEND_LOC_TIMER_MASK |
|
|
- MTK_PHY_LPI_TXPCS_LOC_RCV,
|
|
- FIELD_PREP(MTK_PHY_LPI_SEND_LOC_TIMER_MASK, 0x117));
|
|
+ /* Keep MTK_PHY_LPI_SEND_LOC_TIMER as 375 */
|
|
+ phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG239,
|
|
+ MTK_PHY_LPI_TXPCS_LOC_RCV);
|
|
|
|
+ /* This also fixes some IoT issues, such as CH340 */
|
|
phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG2C7,
|
|
MTK_PHY_MAX_GAIN_MASK | MTK_PHY_MIN_GAIN_MASK,
|
|
FIELD_PREP(MTK_PHY_MAX_GAIN_MASK, 0x8) |
|
|
@@ -912,7 +920,7 @@ static void mt798x_phy_eee(struct phy_de
|
|
__phy_write(phydev, 0x12, 0x0);
|
|
__phy_write(phydev, 0x10, 0x9690);
|
|
|
|
- /* REG_EEE_st2TrKf1000 = 3 */
|
|
+ /* REG_EEE_st2TrKf1000 = 2 */
|
|
__phy_write(phydev, 0x11, 0x114f);
|
|
__phy_write(phydev, 0x12, 0x2);
|
|
__phy_write(phydev, 0x10, 0x969a);
|
|
@@ -937,7 +945,7 @@ static void mt798x_phy_eee(struct phy_de
|
|
__phy_write(phydev, 0x12, 0x0);
|
|
__phy_write(phydev, 0x10, 0x96b8);
|
|
|
|
- /* REGEEE_wake_slv_tr_wait_dfesigdet_en = 1 */
|
|
+ /* REGEEE_wake_slv_tr_wait_dfesigdet_en = 0 */
|
|
__phy_write(phydev, 0x11, 0x1463);
|
|
__phy_write(phydev, 0x12, 0x0);
|
|
__phy_write(phydev, 0x10, 0x96ca);
|
|
@@ -1198,6 +1206,13 @@ static int mt7988_phy_probe(struct phy_d
|
|
|
|
mt798x_phy_setup_led(phydev, mt7988_phy_get_boottrap_polarity(phydev));
|
|
|
|
+ /* Disable TX power saving at probing to:
|
|
+ * 1. Meet common mode compliance test criteria
|
|
+ * 2. Make sure that TX-VCM calibration works fine
|
|
+ */
|
|
+ phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG7,
|
|
+ MTK_PHY_DA_AD_BUF_BIAS_LP_MASK, 0x3 << 8);
|
|
+
|
|
return mt798x_phy_calibration(phydev);
|
|
}
|
|
|