mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-26 17:01:14 +00:00
8f17c019a1
EAP-pwd missing commit validation Published: April 10, 2019 Identifiers: - CVE-2019-9497 (EAP-pwd server not checking for reflection attack) - CVE-2019-9498 (EAP-pwd server missing commit validation for scalar/element) - CVE-2019-9499 (EAP-pwd peer missing commit validation for scalar/element) Latest version available from: https://w1.fi/security/2019-4/ Vulnerability EAP-pwd implementation in hostapd (EAP server) and wpa_supplicant (EAP peer) was discovered not to validate the received scalar and element values in EAP-pwd-Commit messages properly. This could result in attacks that would be able to complete EAP-pwd authentication exchange without the attacker having to know the used password. A reflection attack is possible against the EAP-pwd server since the hostapd EAP server did not verify that the EAP-pwd-Commit contains scalar/element values that differ from the ones the server sent out itself. This allows the attacker to complete EAP-pwd authentication without knowing the password, but this does not result in the attacker being able to derive the session key (MSK), i.e., the attacker would not be able to complete the following key exchange (e.g., 4-way handshake in RSN/WPA). An attack using invalid scalar/element values is possible against both the EAP-pwd server and peer since hostapd and wpa_supplicant did not validate these values in the received EAP-pwd-Commit messages. If the used crypto library does not implement additional checks for the element (EC point), this could result in attacks where the attacker could use a specially crafted commit message values to manipulate the exchange to result in deriving a session key value from a very small set of possible values. This could further be used to attack the EAP-pwd server in a practical manner. An attack against the EAP-pwd peer is slightly more complex, but still consider practical. These invalid scalar/element attacks could result in the attacker being able to complete authentication and learn the session key and MSK to allow the key exchange to be completed as well, i.e., the attacker gaining access to the network in case of the attack against the EAP server or the attacker being able to operate a rogue AP in case of the attack against the EAP peer. While similar attacks might be applicable against SAE, it should be noted that the SAE implementation in hostapd and wpa_supplicant does have the validation steps that were missing from the EAP-pwd implementation and as such, these attacks do not apply to the current SAE implementation. Old versions of wpa_supplicant/hostapd did not include the reflection attack check in the SAE implementation, though, since that was added in June 2015 for v2.5 (commit 6a58444d27fd 'SAE: Verify that own/peer commit-scalar and COMMIT-ELEMENT are different'). Vulnerable versions/configurations All hostapd versions with EAP-pwd support (CONFIG_EAP_PWD=y in the build configuration and EAP-pwd being enabled in the runtime configuration) are vulnerable against the reflection attack. All wpa_supplicant and hostapd versions with EAP-pwd support (CONFIG_EAP_PWD=y in the build configuration and EAP-pwd being enabled in the runtime configuration) are vulnerable against the invalid scalar/element attack when built against a crypto library that does not have an explicit validation step on imported EC points. The following list indicates which cases are vulnerable/not vulnerable: - OpenSSL v1.0.2 or older: vulnerable - OpenSSL v1.1.0 or newer: not vulnerable - BoringSSL with commit 38feb990a183 ('Require that EC points are on the curve.') from September 2015: not vulnerable - BoringSSL without commit 38feb990a183: vulnerable - LibreSSL: vulnerable - wolfssl: vulnerable Acknowledgments Thanks to Mathy Vanhoef (New York University Abu Dhabi) for discovering and reporting the issues and for proposing changes to address them in the implementation. Possible mitigation steps - Merge the following commits to wpa_supplicant/hostapd and rebuild: CVE-2019-9497: EAP-pwd server: Detect reflection attacks CVE-2019-9498: EAP-pwd server: Verify received scalar and element EAP-pwd: Check element x,y coordinates explicitly CVE-2019-9499: EAP-pwd client: Verify received scalar and element EAP-pwd: Check element x,y coordinates explicitly These patches are available from https://w1.fi/security/2019-4/ - Update to wpa_supplicant/hostapd v2.8 or newer, once available Signed-off-by: Stefan Lippers-Hollmann <s.l-h@gmx.de> [bump PKG_RELEASE] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
41 lines
1.5 KiB
Diff
41 lines
1.5 KiB
Diff
From d63edfa90243e9a7de6ae5c275032f2cc79fef95 Mon Sep 17 00:00:00 2001
|
|
From: Mathy Vanhoef <mathy.vanhoef@nyu.edu>
|
|
Date: Sun, 31 Mar 2019 17:26:01 +0200
|
|
Subject: [PATCH 12/14] EAP-pwd server: Detect reflection attacks
|
|
|
|
When processing an EAP-pwd Commit frame, verify that the peer's scalar
|
|
and elliptic curve element differ from the one sent by the server. This
|
|
prevents reflection attacks where the adversary reflects the scalar and
|
|
element sent by the server. (CVE-2019-9497)
|
|
|
|
The vulnerability allows an adversary to complete the EAP-pwd handshake
|
|
as any user. However, the adversary does not learn the negotiated
|
|
session key, meaning the subsequent 4-way handshake would fail. As a
|
|
result, this cannot be abused to bypass authentication unless EAP-pwd is
|
|
used in non-WLAN cases without any following key exchange that would
|
|
require the attacker to learn the MSK.
|
|
|
|
Signed-off-by: Mathy Vanhoef <mathy.vanhoef@nyu.edu>
|
|
---
|
|
src/eap_server/eap_server_pwd.c | 9 +++++++++
|
|
1 file changed, 9 insertions(+)
|
|
|
|
--- a/src/eap_server/eap_server_pwd.c
|
|
+++ b/src/eap_server/eap_server_pwd.c
|
|
@@ -753,6 +753,15 @@ eap_pwd_process_commit_resp(struct eap_s
|
|
}
|
|
}
|
|
|
|
+ /* detect reflection attacks */
|
|
+ if (crypto_bignum_cmp(data->my_scalar, data->peer_scalar) == 0 ||
|
|
+ crypto_ec_point_cmp(data->grp->group, data->my_element,
|
|
+ data->peer_element) == 0) {
|
|
+ wpa_printf(MSG_INFO,
|
|
+ "EAP-PWD (server): detected reflection attack!");
|
|
+ goto fin;
|
|
+ }
|
|
+
|
|
/* compute the shared key, k */
|
|
if ((crypto_ec_point_mul(data->grp->group, data->grp->pwe,
|
|
data->peer_scalar, K) < 0) ||
|