mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-23 07:22:33 +00:00
34d2964554
Fixes issues with RTL8156 2.5G USB adapters
- # ethtool eth1
Settings for eth1:
Supported ports: [ ]
Supported link modes: Not reported
Supported pause frame use: No
Supports auto-negotiation: No
Supported FEC modes: Not reported
Advertised link modes: Not reported
Advertised pause frame use: No
Advertised auto-negotiation: No
Advertised FEC modes: Not reported
Speed: 2500Mb/s
Duplex: Half
Port: Twisted Pair
PHYAD: 0
Transceiver: internal
Auto-negotiation: off
MDI-X: Unknown
Current message level: 0x00000007 (7)
drv probe link
Link detected: yes
- #
- r8152: break the loop when the budget is exhausted
- r8152: Block future register access if register access fails
- r8152: Rename RTL8152_UNPLUG to RTL8152_INACCESSIBLE
- r8152: add vendor/device ID pair for D-Link DUB-E250
- r8152: try to use a normal budget
- r8152: set bp in bulk
- r8152: adjust generic_ocp_write function
- r8152: fix the autosuspend doesn't work
- r8152: Add __GFP_NOWARN to big allocations
- r8152: reduce the control transfer of rtl8152_get_version()
- r8152: remove rtl_vendor_mode function
- r8152: avoid to change cfg for all devices
- r8152: add USB device driver for config selection
- r8152: use napi_gro_frags
- cdc_ether: no need to blacklist any r8152 devices
- cdc_ether: add u-blox 0x1313 composition
Build system: x86_64
Build-tested: bcm2711, rockchip, x86/64
Run-tested: bcm2711/RPi4B, rockchip/nanopi r2s, x86/64
Signed-off-by: Marty Jones <mj8263788@gmail.com>
40 lines
1.4 KiB
Diff
40 lines
1.4 KiB
Diff
From cf74eb5a5bc867258e7d0b0d1c3c4a60e1e3de2f Mon Sep 17 00:00:00 2001
|
|
From: Jakub Kicinski <kuba@kernel.org>
|
|
Date: Mon, 14 Aug 2023 08:35:21 -0700
|
|
Subject: [PATCH] eth: r8152: try to use a normal budget
|
|
|
|
Mario reports that loading r8152 on his system leads to a:
|
|
|
|
netif_napi_add_weight() called with weight 256
|
|
|
|
warning getting printed. We don't have any solid data
|
|
on why such high budget was chosen, and it may cause
|
|
stalls in processing other softirqs and rt threads.
|
|
So try to switch back to the default (64) weight.
|
|
|
|
If this slows down someone's system we should investigate
|
|
which part of stopping starting the NAPI poll in this
|
|
driver are expensive.
|
|
|
|
Reported-by: Mario Limonciello <mario.limonciello@amd.com>
|
|
Link: https://lore.kernel.org/all/0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com/
|
|
Acked-by: Hayes Wang <hayeswang@realtek.com>
|
|
Link: https://lore.kernel.org/r/20230814153521.2697982-1-kuba@kernel.org
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
drivers/net/usb/r8152.c | 3 +--
|
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
|
|
|
--- a/drivers/net/usb/r8152.c
|
|
+++ b/drivers/net/usb/r8152.c
|
|
@@ -9770,8 +9770,7 @@ static int rtl8152_probe(struct usb_inte
|
|
|
|
usb_set_intfdata(intf, tp);
|
|
|
|
- netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
|
|
- tp->support_2500full ? 256 : 64);
|
|
+ netif_napi_add(netdev, &tp->napi, r8152_poll);
|
|
|
|
ret = register_netdev(netdev);
|
|
if (ret != 0) {
|