mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-27 09:12:39 +00:00
a6a8fe0be5
Backport upstream commits. Most interesting 122392e which changes how SERVFAIL is handled especially in event of genuine server down/failure scenarios with multiple servers. a799ca0 also interesting in that answered received via TCP are now cached, DNSSEC typically using TCP meant until now answers weren't cached, hence reducing performance. 59e4703 Free config file values on parsing errors. 48d12f1 Remove the NO_FORK compile-time option, and support for uclinux. 122392e Revert 68f6312d4bae30b78daafcd6f51dc441b8685b1e 3a5a84c Fix Makefile lines generating UBUS linker config. 24b8760 Do not rely on dead code elimination, use array instead. Make options bits derived from size and count. Use size of option bits and last supported bit in computation. No new change would be required when new options are added. Just change OPT_LAST constant. 6f7812d Fix spurious AD flags in some DNS replies from local config. cbb5b17 Fix logging in cf5984367bc6a949e3803a576512c5a7bc48ebab cf59843 Don't forward *.bind/*.server queries upstream ee87504 Remove ability to compile without IPv6 support. a220545 Ensure that AD bit is reset on answers from --address=/<domain>/<address>. a799ca0 Impove cache behaviour for TCP connections. I've been running this for aaaages without obvious issue hence brave step of opening to wider openwrt community. Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
121 lines
3.5 KiB
Diff
121 lines
3.5 KiB
Diff
From 6f7812d97bc8f87004c0a5069c6c94c64af78106 Mon Sep 17 00:00:00 2001
|
|
From: Simon Kelley <simon@thekelleys.org.uk>
|
|
Date: Tue, 23 Oct 2018 23:54:44 +0100
|
|
Subject: [PATCH 06/11] Fix spurious AD flags in some DNS replies from local
|
|
config.
|
|
|
|
Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
|
|
---
|
|
src/rfc1035.c | 42 ++++++++++++++++++++++++------------------
|
|
1 file changed, 24 insertions(+), 18 deletions(-)
|
|
|
|
--- a/src/rfc1035.c
|
|
+++ b/src/rfc1035.c
|
|
@@ -1330,7 +1330,7 @@ size_t answer_request(struct dns_header
|
|
{
|
|
if (t->class == qclass && hostname_isequal(name, t->name))
|
|
{
|
|
- ans = 1;
|
|
+ ans = 1, sec_data = 0;
|
|
if (!dryrun)
|
|
{
|
|
unsigned long ttl = daemon->local_ttl;
|
|
@@ -1370,7 +1370,7 @@ size_t answer_request(struct dns_header
|
|
addr.addr.rcode.rcode = NOTIMP;
|
|
log_query(F_CONFIG | F_RCODE, name, &addr, NULL);
|
|
}
|
|
- ans = 1;
|
|
+ ans = 1, sec_data = 0;
|
|
}
|
|
}
|
|
}
|
|
@@ -1725,7 +1725,7 @@ size_t answer_request(struct dns_header
|
|
}
|
|
else if (is_name_synthetic(flag, name, &addr))
|
|
{
|
|
- ans = 1;
|
|
+ ans = 1, sec_data = 0;
|
|
if (!dryrun)
|
|
{
|
|
log_query(F_FORWARD | F_CONFIG | flag, name, &addr, NULL);
|
|
@@ -1763,25 +1763,27 @@ size_t answer_request(struct dns_header
|
|
for (rec = daemon->mxnames; rec; rec = rec->next)
|
|
if (!rec->issrv && hostname_isequal(name, rec->name))
|
|
{
|
|
- ans = found = 1;
|
|
- if (!dryrun)
|
|
- {
|
|
- int offset;
|
|
- log_query(F_CONFIG | F_RRNAME, name, NULL, "<MX>");
|
|
- if (add_resource_record(header, limit, &trunc, nameoffset, &ansp, daemon->local_ttl,
|
|
- &offset, T_MX, C_IN, "sd", rec->weight, rec->target))
|
|
- {
|
|
- anscount++;
|
|
- if (rec->target)
|
|
- rec->offset = offset;
|
|
- }
|
|
- }
|
|
+ ans = found = 1;
|
|
+ sec_data = 0;
|
|
+ if (!dryrun)
|
|
+ {
|
|
+ int offset;
|
|
+ log_query(F_CONFIG | F_RRNAME, name, NULL, "<MX>");
|
|
+ if (add_resource_record(header, limit, &trunc, nameoffset, &ansp, daemon->local_ttl,
|
|
+ &offset, T_MX, C_IN, "sd", rec->weight, rec->target))
|
|
+ {
|
|
+ anscount++;
|
|
+ if (rec->target)
|
|
+ rec->offset = offset;
|
|
+ }
|
|
+ }
|
|
}
|
|
|
|
if (!found && (option_bool(OPT_SELFMX) || option_bool(OPT_LOCALMX)) &&
|
|
cache_find_by_name(NULL, name, now, F_HOSTS | F_DHCP | F_NO_RR))
|
|
{
|
|
ans = 1;
|
|
+ sec_data = 0;
|
|
if (!dryrun)
|
|
{
|
|
log_query(F_CONFIG | F_RRNAME, name, NULL, "<MX>");
|
|
@@ -1802,6 +1804,7 @@ size_t answer_request(struct dns_header
|
|
if (rec->issrv && hostname_isequal(name, rec->name))
|
|
{
|
|
found = ans = 1;
|
|
+ sec_data = 0;
|
|
if (!dryrun)
|
|
{
|
|
int offset;
|
|
@@ -1838,6 +1841,7 @@ size_t answer_request(struct dns_header
|
|
if (!found && option_bool(OPT_FILTER) && (qtype == T_SRV || (qtype == T_ANY && strchr(name, '_'))))
|
|
{
|
|
ans = 1;
|
|
+ sec_data = 0;
|
|
if (!dryrun)
|
|
log_query(F_CONFIG | F_NEG, name, NULL, NULL);
|
|
}
|
|
@@ -1850,6 +1854,7 @@ size_t answer_request(struct dns_header
|
|
if (hostname_isequal(name, na->name))
|
|
{
|
|
ans = 1;
|
|
+ sec_data = 0;
|
|
if (!dryrun)
|
|
{
|
|
log_query(F_CONFIG | F_RRNAME, name, NULL, "<NAPTR>");
|
|
@@ -1862,11 +1867,12 @@ size_t answer_request(struct dns_header
|
|
}
|
|
|
|
if (qtype == T_MAILB)
|
|
- ans = 1, nxdomain = 1;
|
|
+ ans = 1, nxdomain = 1, sec_data = 0;
|
|
|
|
if (qtype == T_SOA && option_bool(OPT_FILTER))
|
|
{
|
|
- ans = 1;
|
|
+ ans = 1;
|
|
+ sec_data = 0;
|
|
if (!dryrun)
|
|
log_query(F_CONFIG | F_NEG, name, &addr, NULL);
|
|
}
|