mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-23 15:32:33 +00:00
8231f67218
This fixes: 1) Crash during USB disconnect 2) Crash in brcmf_txfinalize() on rmmod with packets queued 3) Some errors in exit path Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
27 lines
1.1 KiB
Diff
27 lines
1.1 KiB
Diff
From bbfab331e3abd9fa8767eea6bf5c4684cdd4b934 Mon Sep 17 00:00:00 2001
|
|
From: Neo Jou <neojou@gmail.com>
|
|
Date: Tue, 21 May 2019 17:12:20 +0800
|
|
Subject: [PATCH] brcmfmac: use strlcpy() instead of strcpy()
|
|
|
|
The function strcpy() is inherently not safe. Though the function
|
|
works without problems here, it would be better to use other safer
|
|
function, e.g. strlcpy(), to replace strcpy() still.
|
|
|
|
Signed-off-by: Neo Jou <neojou@gmail.com>
|
|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
|
---
|
|
drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
|
|
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
|
|
@@ -269,7 +269,7 @@ int brcmf_c_preinit_dcmds(struct brcmf_i
|
|
|
|
/* query for 'ver' to get version info from firmware */
|
|
memset(buf, 0, sizeof(buf));
|
|
- strcpy(buf, "ver");
|
|
+ strlcpy(buf, "ver", sizeof(buf));
|
|
err = brcmf_fil_iovar_data_get(ifp, "ver", buf, sizeof(buf));
|
|
if (err < 0) {
|
|
bphy_err(drvr, "Retrieving version information failed, %d\n",
|