mirror of
https://github.com/openwrt/openwrt.git
synced 2025-03-26 13:49:16 +00:00
6ef0a35bb1
Some checks are pending
Build all core packages / Build all core packages for selected target (push) Waiting to run
As described in #13873, from 23.05.0 onwards logging to a file on an external filesystem fails under some conditions. This occurs because the log initscript had code added to prevent start logging to an external filesystem on boot, and added a trigger to start said logging when the external filesystem gets mounted. The issue is that for filesystems mount with fstab uci, the fstab scripts runs at START=11, while log runs at START=12, which means the external filesystem may already be mounted by the time the log initscript runs. Since the external filesystem is already mounted it does not trigger a hotplug event to trigger the trigger to start logging. This combination means the logging never automatically starts when the log file is on an external filesystem. We therefore add a check for the presence of a mounted filesystem when the log file is being sent to an fstab mounted filesystem. If the filesystem is mounted, we don't skip starting logging during boot. If the filesystem is not mounted then file logging is not started and the trigger will start the logging when the filesystem is mounted. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca> [improved commit message] Signed-off-by: Daniel Golle <daniel@makrotopia.org>