mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-19 05:38:00 +00:00
fd9d1e90b4
Add the 'tmon' packages. This is as a tool to help visualize, tune, and test the complex thermal subsystem. We get a compile warning for the tool that the printf format does not fit. This commit contains a patch that fixes this warning. This patch has also been sent upstream to the Linux kernel [1]. Links: [1] https://lore.kernel.org/all/20231204141335.2798194-1-fe@dev.tdt.de/ Signed-off-by: Florian Eckert <fe@dev.tdt.de>
52 lines
2.1 KiB
Diff
52 lines
2.1 KiB
Diff
From a7a94ca21ac0f347f683d33c72b4aab57ce5eec3 Mon Sep 17 00:00:00 2001
|
|
From: Florian Eckert <fe@dev.tdt.de>
|
|
Date: Mon, 20 Nov 2023 11:13:20 +0100
|
|
Subject: [PATCH] tools/thermal/tmon: Fix compilation warning for wrong format
|
|
|
|
The following warnings are shown during compilation:
|
|
|
|
tui.c: In function 'show_cooling_device':
|
|
tui.c:216:40: warning: format '%d' expects argument of type 'int', but
|
|
argument 7 has type 'long unsigned int' [-Wformat=]
|
|
216 | "%02d %12.12s%6d %6d",
|
|
| ~~^
|
|
| |
|
|
| int
|
|
| %6ld
|
|
......
|
|
219 | ptdata.cdi[j].cur_state,
|
|
| ~~~~~~~~~~~~~~~~~~~~~~~
|
|
| |
|
|
| long unsigned int
|
|
tui.c:216:44: warning: format '%d' expects argument of type 'int', but
|
|
argument 8 has type 'long unsigned int' [-Wformat=]
|
|
216 | "%02d %12.12s%6d %6d",
|
|
| ~~^
|
|
| |
|
|
| int
|
|
| %6ld
|
|
......
|
|
220 | ptdata.cdi[j].max_state);
|
|
| ~~~~~~~~~~~~~~~~~~~~~~~
|
|
| |
|
|
| long unsigned int
|
|
|
|
To fix this, the correct string format must be used for printing.
|
|
|
|
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
|
|
---
|
|
tools/thermal/tmon/tui.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/tools/thermal/tmon/tui.c
|
|
+++ b/tools/thermal/tmon/tui.c
|
|
@@ -213,7 +213,7 @@ void show_cooling_device(void)
|
|
* cooling device instances. skip unused idr.
|
|
*/
|
|
mvwprintw(cooling_device_window, j + 2, 1,
|
|
- "%02d %12.12s%6d %6d",
|
|
+ "%02d %12.12s%6lu %6lu",
|
|
ptdata.cdi[j].instance,
|
|
ptdata.cdi[j].type,
|
|
ptdata.cdi[j].cur_state,
|