mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-21 06:33:41 +00:00
7be79a3ab2
This commit completely fixes the abortion of the ipq40xx ethernet driver probe in case no phy-reset is defined. Signed-off-by: David Bauer <mail@david-bauer.net>
298 lines
8.1 KiB
Diff
298 lines
8.1 KiB
Diff
From 234d6f40fb4b771b396b45a9492aab463771bd0b Mon Sep 17 00:00:00 2001
|
|
From: Kristian Evensen <kristian.evensen@gmail.com>
|
|
Date: Tue, 6 Aug 2019 11:42:57 +0200
|
|
Subject: [PATCH] phy: Add ipq40xx mdio driver
|
|
|
|
---
|
|
drivers/net/phy/Kconfig | 7 +
|
|
drivers/net/phy/Makefile | 1 +
|
|
drivers/net/phy/mdio-ipq40xx.c | 247 +++++++++++++++++++++++++++++++++
|
|
3 files changed, 255 insertions(+)
|
|
create mode 100644 drivers/net/phy/mdio-ipq40xx.c
|
|
|
|
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
|
|
index 1f5fd24cd..eb71b47a3 100644
|
|
--- a/drivers/net/phy/Kconfig
|
|
+++ b/drivers/net/phy/Kconfig
|
|
@@ -436,6 +436,13 @@ config XILINX_GMII2RGMII
|
|
the Reduced Gigabit Media Independent Interface(RGMII) between
|
|
Ethernet physical media devices and the Gigabit Ethernet controller.
|
|
|
|
+config MDIO_IPQ40XX
|
|
+ tristate "Qualcomm Atheros ipq40xx MDIO interface"
|
|
+ depends on HAS_IOMEM && OF
|
|
+ ---help---
|
|
+ This driver supports the MDIO interface found in Qualcomm
|
|
+ Atheros ipq40xx Soc chip.
|
|
+
|
|
endif # PHYLIB
|
|
|
|
config MICREL_KS8995MA
|
|
diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
|
|
index f21cda9d8..804c52634 100644
|
|
--- a/drivers/net/phy/Makefile
|
|
+++ b/drivers/net/phy/Makefile
|
|
@@ -33,6 +33,7 @@ obj-$(CONFIG_MDIO_CAVIUM) += mdio-cavium.o
|
|
obj-$(CONFIG_MDIO_GPIO) += mdio-gpio.o
|
|
obj-$(CONFIG_MDIO_HISI_FEMAC) += mdio-hisi-femac.o
|
|
obj-$(CONFIG_MDIO_I2C) += mdio-i2c.o
|
|
+obj-$(CONFIG_MDIO_IPQ40XX) += mdio-ipq40xx.o
|
|
obj-$(CONFIG_MDIO_MOXART) += mdio-moxart.o
|
|
obj-$(CONFIG_MDIO_MSCC_MIIM) += mdio-mscc-miim.o
|
|
obj-$(CONFIG_MDIO_OCTEON) += mdio-octeon.o
|
|
diff --git a/drivers/net/phy/mdio-ipq40xx.c b/drivers/net/phy/mdio-ipq40xx.c
|
|
new file mode 100644
|
|
index 000000000..88fe5dc2b
|
|
--- /dev/null
|
|
+++ b/drivers/net/phy/mdio-ipq40xx.c
|
|
@@ -0,0 +1,247 @@
|
|
+/*
|
|
+ * Copyright (c) 2015-2016, The Linux Foundation. All rights reserved.
|
|
+ *
|
|
+ * Permission to use, copy, modify, and/or distribute this software for
|
|
+ * any purpose with or without fee is hereby granted, provided that the
|
|
+ * above copyright notice and this permission notice appear in all copies.
|
|
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
|
|
+ * OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
+ */
|
|
+
|
|
+#include <linux/delay.h>
|
|
+#include <linux/kernel.h>
|
|
+#include <linux/module.h>
|
|
+#include <linux/mutex.h>
|
|
+#include <linux/io.h>
|
|
+#include <linux/of_address.h>
|
|
+#include <linux/of_mdio.h>
|
|
+#include <linux/of_gpio.h>
|
|
+#include <linux/phy.h>
|
|
+#include <linux/platform_device.h>
|
|
+#include <linux/gpio.h>
|
|
+
|
|
+#define MDIO_CTRL_0_REG 0x40
|
|
+#define MDIO_CTRL_1_REG 0x44
|
|
+#define MDIO_CTRL_2_REG 0x48
|
|
+#define MDIO_CTRL_3_REG 0x4c
|
|
+#define MDIO_CTRL_4_REG 0x50
|
|
+#define MDIO_CTRL_4_ACCESS_BUSY BIT(16)
|
|
+#define MDIO_CTRL_4_ACCESS_START BIT(8)
|
|
+#define MDIO_CTRL_4_ACCESS_CODE_READ 0
|
|
+#define MDIO_CTRL_4_ACCESS_CODE_WRITE 1
|
|
+#define CTRL_0_REG_DEFAULT_VALUE 0x150FF
|
|
+
|
|
+#define IPQ40XX_MDIO_RETRY 1000
|
|
+#define IPQ40XX_MDIO_DELAY 10
|
|
+
|
|
+struct ipq40xx_mdio_data {
|
|
+ struct mii_bus *mii_bus;
|
|
+ void __iomem *membase;
|
|
+ struct device *dev;
|
|
+};
|
|
+
|
|
+static int ipq40xx_mdio_wait_busy(struct ipq40xx_mdio_data *am)
|
|
+{
|
|
+ int i;
|
|
+
|
|
+ for (i = 0; i < IPQ40XX_MDIO_RETRY; i++) {
|
|
+ unsigned int busy;
|
|
+
|
|
+ busy = readl(am->membase + MDIO_CTRL_4_REG) &
|
|
+ MDIO_CTRL_4_ACCESS_BUSY;
|
|
+ if (!busy)
|
|
+ return 0;
|
|
+
|
|
+ /* BUSY might take to be cleard by 15~20 times of loop */
|
|
+ udelay(IPQ40XX_MDIO_DELAY);
|
|
+ }
|
|
+
|
|
+ dev_err(am->dev, "%s: MDIO operation timed out\n", am->mii_bus->name);
|
|
+
|
|
+ return -ETIMEDOUT;
|
|
+}
|
|
+
|
|
+static int ipq40xx_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
|
|
+{
|
|
+ struct ipq40xx_mdio_data *am = bus->priv;
|
|
+ int value = 0;
|
|
+ unsigned int cmd = 0;
|
|
+
|
|
+ lockdep_assert_held(&bus->mdio_lock);
|
|
+
|
|
+ if (ipq40xx_mdio_wait_busy(am))
|
|
+ return -ETIMEDOUT;
|
|
+
|
|
+ /* issue the phy address and reg */
|
|
+ writel((mii_id << 8) | regnum, am->membase + MDIO_CTRL_1_REG);
|
|
+
|
|
+ cmd = MDIO_CTRL_4_ACCESS_START|MDIO_CTRL_4_ACCESS_CODE_READ;
|
|
+
|
|
+ /* issue read command */
|
|
+ writel(cmd, am->membase + MDIO_CTRL_4_REG);
|
|
+
|
|
+ /* Wait read complete */
|
|
+ if (ipq40xx_mdio_wait_busy(am))
|
|
+ return -ETIMEDOUT;
|
|
+
|
|
+ /* Read data */
|
|
+ value = readl(am->membase + MDIO_CTRL_3_REG);
|
|
+
|
|
+ return value;
|
|
+}
|
|
+
|
|
+static int ipq40xx_mdio_write(struct mii_bus *bus, int mii_id, int regnum,
|
|
+ u16 value)
|
|
+{
|
|
+ struct ipq40xx_mdio_data *am = bus->priv;
|
|
+ unsigned int cmd = 0;
|
|
+
|
|
+ lockdep_assert_held(&bus->mdio_lock);
|
|
+
|
|
+ if (ipq40xx_mdio_wait_busy(am))
|
|
+ return -ETIMEDOUT;
|
|
+
|
|
+ /* issue the phy address and reg */
|
|
+ writel((mii_id << 8) | regnum, am->membase + MDIO_CTRL_1_REG);
|
|
+
|
|
+ /* issue write data */
|
|
+ writel(value, am->membase + MDIO_CTRL_2_REG);
|
|
+
|
|
+ cmd = MDIO_CTRL_4_ACCESS_START|MDIO_CTRL_4_ACCESS_CODE_WRITE;
|
|
+ /* issue write command */
|
|
+ writel(cmd, am->membase + MDIO_CTRL_4_REG);
|
|
+
|
|
+ /* Wait write complete */
|
|
+ if (ipq40xx_mdio_wait_busy(am))
|
|
+ return -ETIMEDOUT;
|
|
+
|
|
+ return 0;
|
|
+}
|
|
+
|
|
+static int ipq40xx_phy_reset(struct platform_device *pdev)
|
|
+{
|
|
+ struct device_node *mdio_node;
|
|
+ int phy_reset_gpio_number;
|
|
+ int ret;
|
|
+
|
|
+ mdio_node = of_find_node_by_name(NULL, "mdio");
|
|
+ if (!mdio_node) {
|
|
+ dev_err(&pdev->dev, "Could not find mdio node\n");
|
|
+ return 0;
|
|
+ }
|
|
+
|
|
+ ret = of_get_named_gpio(mdio_node, "phy-reset-gpio", 0);
|
|
+ if (ret < 0) {
|
|
+ dev_err(&pdev->dev, "Could not find phy-reset-gpio\n");
|
|
+ return 0;
|
|
+ }
|
|
+
|
|
+ phy_reset_gpio_number = ret;
|
|
+
|
|
+ ret = gpio_request(phy_reset_gpio_number, "phy-reset-gpio");
|
|
+ if (ret) {
|
|
+ dev_err(&pdev->dev, "Can't get phy-reset-gpio %d\n", ret);
|
|
+ return ret;
|
|
+ }
|
|
+
|
|
+ ret = gpio_direction_output(phy_reset_gpio_number, 0x0);
|
|
+ if (ret) {
|
|
+ dev_err(&pdev->dev,
|
|
+ "Can't set direction for phy-reset-gpio %d\n", ret);
|
|
+ goto phy_reset_out;
|
|
+ }
|
|
+
|
|
+ usleep_range(1000, 10005);
|
|
+
|
|
+ gpio_set_value(phy_reset_gpio_number, 0x01);
|
|
+
|
|
+phy_reset_out:
|
|
+ gpio_free(phy_reset_gpio_number);
|
|
+
|
|
+ return ret;
|
|
+}
|
|
+
|
|
+static int ipq40xx_mdio_probe(struct platform_device *pdev)
|
|
+{
|
|
+ struct ipq40xx_mdio_data *am;
|
|
+ struct resource *res;
|
|
+ int i, ret;
|
|
+
|
|
+ ret = ipq40xx_phy_reset(pdev);
|
|
+ if (ret) {
|
|
+ dev_err(&pdev->dev, "Could not find qca8075 reset gpio\n");
|
|
+ return -ENODEV;
|
|
+ }
|
|
+
|
|
+ am = devm_kzalloc(&pdev->dev, sizeof(*am), GFP_KERNEL);
|
|
+ if (!am)
|
|
+ return -ENOMEM;
|
|
+
|
|
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
+ if (!res) {
|
|
+ dev_err(&pdev->dev, "no iomem resource found\n");
|
|
+ return -ENXIO;
|
|
+ }
|
|
+
|
|
+ am->membase = devm_ioremap_resource(&pdev->dev, res);
|
|
+ if (IS_ERR(am->membase)) {
|
|
+ dev_err(&pdev->dev, "unable to ioremap registers\n");
|
|
+ return PTR_ERR(am->membase);
|
|
+ }
|
|
+
|
|
+ am->mii_bus = devm_mdiobus_alloc(&pdev->dev);
|
|
+ if (!am->mii_bus)
|
|
+ return -ENOMEM;
|
|
+
|
|
+ writel(CTRL_0_REG_DEFAULT_VALUE, am->membase + MDIO_CTRL_0_REG);
|
|
+
|
|
+ am->mii_bus->name = "ipq40xx_mdio";
|
|
+ am->mii_bus->read = ipq40xx_mdio_read;
|
|
+ am->mii_bus->write = ipq40xx_mdio_write;
|
|
+ am->mii_bus->priv = am;
|
|
+ am->mii_bus->parent = &pdev->dev;
|
|
+ snprintf(am->mii_bus->id, MII_BUS_ID_SIZE, "%s", dev_name(&pdev->dev));
|
|
+
|
|
+ am->dev = &pdev->dev;
|
|
+ platform_set_drvdata(pdev, am);
|
|
+
|
|
+ return of_mdiobus_register(am->mii_bus, pdev->dev.of_node);
|
|
+}
|
|
+
|
|
+static int ipq40xx_mdio_remove(struct platform_device *pdev)
|
|
+{
|
|
+ struct ipq40xx_mdio_data *am = platform_get_drvdata(pdev);
|
|
+
|
|
+ mdiobus_unregister(am->mii_bus);
|
|
+
|
|
+ return 0;
|
|
+}
|
|
+
|
|
+static const struct of_device_id ipq40xx_mdio_dt_ids[] = {
|
|
+ { .compatible = "qcom,ipq4019-mdio" },
|
|
+ { }
|
|
+};
|
|
+MODULE_DEVICE_TABLE(of, ipq40xx_mdio_dt_ids);
|
|
+
|
|
+static struct platform_driver ipq40xx_mdio_driver = {
|
|
+ .probe = ipq40xx_mdio_probe,
|
|
+ .remove = ipq40xx_mdio_remove,
|
|
+ .driver = {
|
|
+ .name = "ipq40xx-mdio",
|
|
+ .of_match_table = ipq40xx_mdio_dt_ids,
|
|
+ },
|
|
+};
|
|
+
|
|
+module_platform_driver(ipq40xx_mdio_driver);
|
|
+
|
|
+#define DRV_VERSION "1.0"
|
|
+
|
|
+MODULE_DESCRIPTION("IPQ40XX MDIO interface driver");
|
|
+MODULE_AUTHOR("Qualcomm Atheros");
|
|
+MODULE_VERSION(DRV_VERSION);
|
|
+MODULE_LICENSE("Dual BSD/GPL");
|
|
--
|
|
2.20.1
|