mirror of
https://github.com/openwrt/openwrt.git
synced 2025-01-10 23:12:48 +00:00
56b2d856a2
7a3bcd39ae1f r8169: use helper r8169_mod_reg8_cond to simplify rtl_jumbo_config
e3e9e9039fa6 r8169: align WAKE_PHY handling with r8125/r8126 vendor drivers
330dc2297c82 r8169: improve rtl_set_d3_pll_down
c507e96b5763 r8169: improve __rtl8169_set_wol
83cb4b470c66 r8169: remove leftover locks after reverted change
2cd02f2fdd8a r8169: improve initialization of RSS registers on RTL8125/RTL8126
a3d8520e6a19 r8169: align RTL8126 EEE config with vendor driver
4af2f60bf737 r8169: align RTL8125/RTL8126 PHY config with vendor driver
eb90f876b796 r8169: align RTL8125 EEE config with vendor driver
b8bd8c44a266 r8169: fix inconsistent indenting in rtl8169_get_eth_mac_stats
f75d1fbe7809 r8169: add support for RTL8125D
c4e64095c00c r8169: enable EEE at 2.5G per default on RTL8125B
d64113c6bb5e r8169: remove rtl_dash_loop_wait_high/low
1c105bacb160 r8169: avoid duplicated messages if loading firmware fails and switch to warn level
ac48430368c1 r8169: don't take RTNL lock in rtl_task()
e3fc5139bd8f r8169: implement additional ethtool stats ops
b8bf38440ba9 r8169: enable SG/TSO on selected chip versions per default
854d71c555df r8169: remove original workaround for RTL8125 broken rx issue
1ffcc8d41306 r8169: add support for the temperature sensor being available from RTL8125B
The following patches require backporting additional linux patches:
e2015942e90a r8169: replace custom flag with disable_work() et al
e340bff27e63 r8169: copy vendor driver 2.5G/5G EEE advertisement constraints
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
(cherry picked from commit 0eeba04a16)
114 lines
3.5 KiB
Diff
114 lines
3.5 KiB
Diff
From 83cb4b470c66b37b19a347a35cea01e0cbdd258d Mon Sep 17 00:00:00 2001
|
|
From: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Date: Mon, 4 Nov 2024 23:16:20 +0100
|
|
Subject: [PATCH] r8169: remove leftover locks after reverted change
|
|
|
|
After e31a9fedc7d8 ("Revert "r8169: disable ASPM during NAPI poll"")
|
|
these locks aren't needed any longer.
|
|
|
|
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Link: https://patch.msgid.link/680f2606-ac7d-4ced-8694-e5033855da9b@gmail.com
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
drivers/net/ethernet/realtek/r8169_main.c | 29 ++---------------------
|
|
1 file changed, 2 insertions(+), 27 deletions(-)
|
|
|
|
--- a/drivers/net/ethernet/realtek/r8169_main.c
|
|
+++ b/drivers/net/ethernet/realtek/r8169_main.c
|
|
@@ -663,13 +663,9 @@ struct rtl8169_private {
|
|
struct work_struct work;
|
|
} wk;
|
|
|
|
- raw_spinlock_t config25_lock;
|
|
raw_spinlock_t mac_ocp_lock;
|
|
struct mutex led_lock; /* serialize LED ctrl RMW access */
|
|
|
|
- raw_spinlock_t cfg9346_usage_lock;
|
|
- int cfg9346_usage_count;
|
|
-
|
|
unsigned supports_gmii:1;
|
|
unsigned aspm_manageable:1;
|
|
unsigned dash_enabled:1;
|
|
@@ -723,22 +719,12 @@ static inline struct device *tp_to_dev(s
|
|
|
|
static void rtl_lock_config_regs(struct rtl8169_private *tp)
|
|
{
|
|
- unsigned long flags;
|
|
-
|
|
- raw_spin_lock_irqsave(&tp->cfg9346_usage_lock, flags);
|
|
- if (!--tp->cfg9346_usage_count)
|
|
- RTL_W8(tp, Cfg9346, Cfg9346_Lock);
|
|
- raw_spin_unlock_irqrestore(&tp->cfg9346_usage_lock, flags);
|
|
+ RTL_W8(tp, Cfg9346, Cfg9346_Lock);
|
|
}
|
|
|
|
static void rtl_unlock_config_regs(struct rtl8169_private *tp)
|
|
{
|
|
- unsigned long flags;
|
|
-
|
|
- raw_spin_lock_irqsave(&tp->cfg9346_usage_lock, flags);
|
|
- if (!tp->cfg9346_usage_count++)
|
|
- RTL_W8(tp, Cfg9346, Cfg9346_Unlock);
|
|
- raw_spin_unlock_irqrestore(&tp->cfg9346_usage_lock, flags);
|
|
+ RTL_W8(tp, Cfg9346, Cfg9346_Unlock);
|
|
}
|
|
|
|
static void rtl_pci_commit(struct rtl8169_private *tp)
|
|
@@ -749,24 +735,18 @@ static void rtl_pci_commit(struct rtl816
|
|
|
|
static void rtl_mod_config2(struct rtl8169_private *tp, u8 clear, u8 set)
|
|
{
|
|
- unsigned long flags;
|
|
u8 val;
|
|
|
|
- raw_spin_lock_irqsave(&tp->config25_lock, flags);
|
|
val = RTL_R8(tp, Config2);
|
|
RTL_W8(tp, Config2, (val & ~clear) | set);
|
|
- raw_spin_unlock_irqrestore(&tp->config25_lock, flags);
|
|
}
|
|
|
|
static void rtl_mod_config5(struct rtl8169_private *tp, u8 clear, u8 set)
|
|
{
|
|
- unsigned long flags;
|
|
u8 val;
|
|
|
|
- raw_spin_lock_irqsave(&tp->config25_lock, flags);
|
|
val = RTL_R8(tp, Config5);
|
|
RTL_W8(tp, Config5, (val & ~clear) | set);
|
|
- raw_spin_unlock_irqrestore(&tp->config25_lock, flags);
|
|
}
|
|
|
|
static bool rtl_is_8125(struct rtl8169_private *tp)
|
|
@@ -1572,7 +1552,6 @@ static void __rtl8169_set_wol(struct rtl
|
|
{ WAKE_MAGIC, Config3, MagicPacket }
|
|
};
|
|
unsigned int i, tmp = ARRAY_SIZE(cfg);
|
|
- unsigned long flags;
|
|
u8 options;
|
|
|
|
rtl_unlock_config_regs(tp);
|
|
@@ -1591,14 +1570,12 @@ static void __rtl8169_set_wol(struct rtl
|
|
r8168_mac_ocp_modify(tp, 0xc0b6, BIT(0), 0);
|
|
}
|
|
|
|
- raw_spin_lock_irqsave(&tp->config25_lock, flags);
|
|
for (i = 0; i < tmp; i++) {
|
|
options = RTL_R8(tp, cfg[i].reg) & ~cfg[i].mask;
|
|
if (wolopts & cfg[i].opt)
|
|
options |= cfg[i].mask;
|
|
RTL_W8(tp, cfg[i].reg, options);
|
|
}
|
|
- raw_spin_unlock_irqrestore(&tp->config25_lock, flags);
|
|
|
|
switch (tp->mac_version) {
|
|
case RTL_GIGA_MAC_VER_02 ... RTL_GIGA_MAC_VER_06:
|
|
@@ -5498,8 +5475,6 @@ static int rtl_init_one(struct pci_dev *
|
|
tp->supports_gmii = ent->driver_data == RTL_CFG_NO_GBIT ? 0 : 1;
|
|
tp->ocp_base = OCP_STD_PHY_BASE;
|
|
|
|
- raw_spin_lock_init(&tp->cfg9346_usage_lock);
|
|
- raw_spin_lock_init(&tp->config25_lock);
|
|
raw_spin_lock_init(&tp->mac_ocp_lock);
|
|
mutex_init(&tp->led_lock);
|
|
|