mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-24 15:56:49 +00:00
498f1f4f5d
Looking at the current upstream driver implementation, it seems like the
TX/RX flow control is enabled only if the flow control pause option is
resolved from the device/link partner advertisements (or otherwise set).
On the other hand, our current in-tree driver force enables TX/RX
flow control by default, thus possibly leading to TX timeouts if the
other end sends pause frames (which are not properly handled?):
WARNING: CPU: 3 PID: 0 at net/sched/sch_generic.c:320 dev_watchdog+0x1ac/0x324
NETDEV WATCHDOG: eth0 (mtk_soc_eth): transmit queue 0 timed out
Disabling the flow control on PORT 5 MAC seems to fix this issues as the
pause frames are then filtered out. While at it, I'm removing the if
condition completely as suggested, since this code is run only on mt7621
SoC, so there is no need to check for the silicon revisions.
Ref: https://lists.openwrt.org/pipermail/openwrt-devel/2017-November/009882.html
Ref: https://forum.openwrt.org/t/mtk-soc-eth-watchdog-timeout-after-r11573/50000/12
Suggested-by: Felix Fietkau <nbd@nbd.name>
Reported-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| esw_rt3050.c | ||
| esw_rt3050.h | ||
| ethtool.c | ||
| ethtool.h | ||
| gsw_mt7620.c | ||
| gsw_mt7620.h | ||
| gsw_mt7621.c | ||
| Kconfig | ||
| Makefile | ||
| mdio_mt7620.c | ||
| mdio_rt2880.c | ||
| mdio_rt2880.h | ||
| mdio.c | ||
| mdio.h | ||
| mt7530.c | ||
| mt7530.h | ||
| mtk_debugfs.c | ||
| mtk_eth_soc.c | ||
| mtk_eth_soc.h | ||
| mtk_offload.c | ||
| mtk_offload.h | ||
| soc_mt7620.c | ||
| soc_mt7621.c | ||
| soc_rt2880.c | ||
| soc_rt3050.c | ||
| soc_rt3883.c | ||