mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-24 07:46:48 +00:00
45bad8ba98
Backport newly introduced support for 'active-high' property and use
it to correctly implement polarity assignment for Aquantia PHY LEDs.
Previously the 'active-low' property was used to switch a LED PIN to
active-high ("drive VDD" in Aquantia-speak) mode.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
54 lines
1.9 KiB
Diff
54 lines
1.9 KiB
Diff
From a274465cc3bef2dfd9c9ea5100848dda0a8641e1 Mon Sep 17 00:00:00 2001
|
|
From: Daniel Golle <daniel@makrotopia.org>
|
|
Date: Thu, 10 Oct 2024 13:54:19 +0100
|
|
Subject: [PATCH 1/4] net: phy: support 'active-high' property for PHY LEDs
|
|
|
|
In addition to 'active-low' and 'inactive-high-impedance' also
|
|
support 'active-high' property for PHY LED pin configuration.
|
|
As only either 'active-high' or 'active-low' can be set at the
|
|
same time, WARN and return an error in case both are set.
|
|
|
|
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
|
|
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
|
|
Link: https://patch.msgid.link/91598487773d768f254d5faf06cf65b13e972f0e.1728558223.git.daniel@makrotopia.org
|
|
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
|
|
---
|
|
drivers/net/phy/phy_device.c | 6 ++++++
|
|
include/linux/phy.h | 5 +++--
|
|
2 files changed, 9 insertions(+), 2 deletions(-)
|
|
|
|
--- a/drivers/net/phy/phy_device.c
|
|
+++ b/drivers/net/phy/phy_device.c
|
|
@@ -3219,11 +3219,17 @@ static int of_phy_led(struct phy_device
|
|
if (index > U8_MAX)
|
|
return -EINVAL;
|
|
|
|
+ if (of_property_read_bool(led, "active-high"))
|
|
+ set_bit(PHY_LED_ACTIVE_HIGH, &modes);
|
|
if (of_property_read_bool(led, "active-low"))
|
|
set_bit(PHY_LED_ACTIVE_LOW, &modes);
|
|
if (of_property_read_bool(led, "inactive-high-impedance"))
|
|
set_bit(PHY_LED_INACTIVE_HIGH_IMPEDANCE, &modes);
|
|
|
|
+ if (WARN_ON(modes & BIT(PHY_LED_ACTIVE_LOW) &&
|
|
+ modes & BIT(PHY_LED_ACTIVE_HIGH)))
|
|
+ return -EINVAL;
|
|
+
|
|
if (modes) {
|
|
/* Return error if asked to set polarity modes but not supported */
|
|
if (!phydev->drv->led_polarity_set)
|
|
--- a/include/linux/phy.h
|
|
+++ b/include/linux/phy.h
|
|
@@ -872,8 +872,9 @@ struct phy_led {
|
|
|
|
/* Modes for PHY LED configuration */
|
|
enum phy_led_modes {
|
|
- PHY_LED_ACTIVE_LOW = 0,
|
|
- PHY_LED_INACTIVE_HIGH_IMPEDANCE = 1,
|
|
+ PHY_LED_ACTIVE_HIGH = 0,
|
|
+ PHY_LED_ACTIVE_LOW = 1,
|
|
+ PHY_LED_INACTIVE_HIGH_IMPEDANCE = 2,
|
|
|
|
/* keep it last */
|
|
__PHY_LED_MODES_NUM,
|