openwrt/target/linux/brcm2708/patches-4.19/950-0125-sound-bcm-Fix-memset-dereference-warning.patch
Álvaro Fernández Rojas 4295485719 brcm2708: add linux 4.19 support
Boot tested on Raspberry Pi B+ (BCM2708) and Raspberry Pi 2 (BCM2709)

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
2019-07-14 12:44:14 +02:00

37 lines
1.4 KiB
Diff
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

From 943530f05c0bb81679b1413c4a545e4600f61f71 Mon Sep 17 00:00:00 2001
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Sun, 4 Mar 2018 17:20:25 -0700
Subject: [PATCH 125/703] sound: bcm: Fix memset dereference warning
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This warning appears with GCC 6.4.0 from toolchains.bootlin.com:
../sound/soc/bcm/allo-piano-dac-plus.c: In function snd_allo_piano_dac_init:
../sound/soc/bcm/allo-piano-dac-plus.c:711:30: warning: argument to sizeof in memset call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
memset(glb_ptr, 0x00, sizeof(glb_ptr));
^
Suggested-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
sound/soc/bcm/allo-piano-dac-plus.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/sound/soc/bcm/allo-piano-dac-plus.c
+++ b/sound/soc/bcm/allo-piano-dac-plus.c
@@ -706,11 +706,10 @@ static int snd_allo_piano_dac_init(struc
struct snd_soc_card *card = rtd->card;
struct glb_pool *glb_ptr;
- glb_ptr = kmalloc(sizeof(struct glb_pool), GFP_KERNEL);
+ glb_ptr = kzalloc(sizeof(struct glb_pool), GFP_KERNEL);
if (!glb_ptr)
return -ENOMEM;
- memset(glb_ptr, 0x00, sizeof(glb_ptr));
card->drvdata = glb_ptr;
glb_ptr->dual_mode = 2;
glb_ptr->set_mode = 0;