mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-26 17:01:14 +00:00
4070e2a64c
This target adds support for the StarFive JH7100 and JH7110 SoCs, based on 6.1, as well as a couple boards equipped with these. Specifications: SoCs: JH7100: - StarFive JH7100 dual-core RISC-V (U74, RC64GC) - additional monitoring (S7) and control (E24) cores - 2Mb L2 cache JH7110: - StarFive JH7110 quad-core RISC-V (U74, RV64GC) - additional monitoring (S7) and control (E24) cores - 2Mb L2 cache Boards: VisionFive1: - JH7100 @ 1GHz - Memory: 8Gb LPDDR4 - 4x USB3.0 - 1x GBit ethernet - AMPak 6236 wifi / bluetooth - audio - powered via USB-C VisionFive2: - JH7110 @ 1.5GHz - Memory: 2/4/8Gb DDR4 - 2x Gbit ethernet - 2x USB3.0 / 2x USB2.0 - eMMC / SDIO - various multimedia input/outputs (MIPI CSI, HDMI, audio) - M.2 key M slot - PoE support - powered via USB-C Installation: Standard SD-card installation via dd-ing the generated image to an SD-card of at least 256Mb. Signed-off-by: Zoltan HERPAI <wigyori@uid0.hu>
147 lines
5.2 KiB
Diff
147 lines
5.2 KiB
Diff
From 365bb978e5e11a16c362d9c2c64d7bf8d04999df Mon Sep 17 00:00:00 2001
|
|
From: Emil Renner Berthing <kernel@esmil.dk>
|
|
Date: Sat, 1 Apr 2023 19:19:24 +0800
|
|
Subject: [PATCH 012/122] reset: starfive: jh71x0: Use 32bit I/O on 32bit
|
|
registers
|
|
|
|
We currently use 64bit I/O on the 32bit registers. This works because
|
|
there are an even number of assert and status registers, so they're only
|
|
ever accessed in pairs on 64bit boundaries.
|
|
|
|
There are however other reset controllers for audio and video on the
|
|
JH7100 SoC with only one status register that isn't 64bit aligned so
|
|
64bit I/O results in an unaligned access exception.
|
|
|
|
Switch to 32bit I/O in preparation for supporting these resets too.
|
|
|
|
Tested-by: Tommaso Merciai <tomm.merciai@gmail.com>
|
|
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
|
|
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
|
|
Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
|
|
Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
|
|
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
|
|
---
|
|
.../reset/starfive/reset-starfive-jh7100.c | 14 ++++-----
|
|
.../reset/starfive/reset-starfive-jh71x0.c | 31 +++++++++----------
|
|
.../reset/starfive/reset-starfive-jh71x0.h | 2 +-
|
|
3 files changed, 23 insertions(+), 24 deletions(-)
|
|
|
|
--- a/drivers/reset/starfive/reset-starfive-jh7100.c
|
|
+++ b/drivers/reset/starfive/reset-starfive-jh7100.c
|
|
@@ -30,16 +30,16 @@
|
|
* lines don't though, so store the expected value of the status registers when
|
|
* all lines are asserted.
|
|
*/
|
|
-static const u64 jh7100_reset_asserted[2] = {
|
|
+static const u32 jh7100_reset_asserted[4] = {
|
|
/* STATUS0 */
|
|
- BIT_ULL_MASK(JH7100_RST_U74) |
|
|
- BIT_ULL_MASK(JH7100_RST_VP6_DRESET) |
|
|
- BIT_ULL_MASK(JH7100_RST_VP6_BRESET) |
|
|
+ BIT(JH7100_RST_U74 % 32) |
|
|
+ BIT(JH7100_RST_VP6_DRESET % 32) |
|
|
+ BIT(JH7100_RST_VP6_BRESET % 32),
|
|
/* STATUS1 */
|
|
- BIT_ULL_MASK(JH7100_RST_HIFI4_DRESET) |
|
|
- BIT_ULL_MASK(JH7100_RST_HIFI4_BRESET),
|
|
+ BIT(JH7100_RST_HIFI4_DRESET % 32) |
|
|
+ BIT(JH7100_RST_HIFI4_BRESET % 32),
|
|
/* STATUS2 */
|
|
- BIT_ULL_MASK(JH7100_RST_E24) |
|
|
+ BIT(JH7100_RST_E24 % 32),
|
|
/* STATUS3 */
|
|
0,
|
|
};
|
|
--- a/drivers/reset/starfive/reset-starfive-jh71x0.c
|
|
+++ b/drivers/reset/starfive/reset-starfive-jh71x0.c
|
|
@@ -8,7 +8,6 @@
|
|
#include <linux/bitmap.h>
|
|
#include <linux/device.h>
|
|
#include <linux/io.h>
|
|
-#include <linux/io-64-nonatomic-lo-hi.h>
|
|
#include <linux/iopoll.h>
|
|
#include <linux/reset-controller.h>
|
|
#include <linux/spinlock.h>
|
|
@@ -21,7 +20,7 @@ struct jh71x0_reset {
|
|
spinlock_t lock;
|
|
void __iomem *assert;
|
|
void __iomem *status;
|
|
- const u64 *asserted;
|
|
+ const u32 *asserted;
|
|
};
|
|
|
|
static inline struct jh71x0_reset *
|
|
@@ -34,12 +33,12 @@ static int jh71x0_reset_update(struct re
|
|
unsigned long id, bool assert)
|
|
{
|
|
struct jh71x0_reset *data = jh71x0_reset_from(rcdev);
|
|
- unsigned long offset = BIT_ULL_WORD(id);
|
|
- u64 mask = BIT_ULL_MASK(id);
|
|
- void __iomem *reg_assert = data->assert + offset * sizeof(u64);
|
|
- void __iomem *reg_status = data->status + offset * sizeof(u64);
|
|
- u64 done = data->asserted ? data->asserted[offset] & mask : 0;
|
|
- u64 value;
|
|
+ unsigned long offset = id / 32;
|
|
+ u32 mask = BIT(id % 32);
|
|
+ void __iomem *reg_assert = data->assert + offset * sizeof(u32);
|
|
+ void __iomem *reg_status = data->status + offset * sizeof(u32);
|
|
+ u32 done = data->asserted ? data->asserted[offset] & mask : 0;
|
|
+ u32 value;
|
|
unsigned long flags;
|
|
int ret;
|
|
|
|
@@ -48,15 +47,15 @@ static int jh71x0_reset_update(struct re
|
|
|
|
spin_lock_irqsave(&data->lock, flags);
|
|
|
|
- value = readq(reg_assert);
|
|
+ value = readl(reg_assert);
|
|
if (assert)
|
|
value |= mask;
|
|
else
|
|
value &= ~mask;
|
|
- writeq(value, reg_assert);
|
|
+ writel(value, reg_assert);
|
|
|
|
/* if the associated clock is gated, deasserting might otherwise hang forever */
|
|
- ret = readq_poll_timeout_atomic(reg_status, value, (value & mask) == done, 0, 1000);
|
|
+ ret = readl_poll_timeout_atomic(reg_status, value, (value & mask) == done, 0, 1000);
|
|
|
|
spin_unlock_irqrestore(&data->lock, flags);
|
|
return ret;
|
|
@@ -90,10 +89,10 @@ static int jh71x0_reset_status(struct re
|
|
unsigned long id)
|
|
{
|
|
struct jh71x0_reset *data = jh71x0_reset_from(rcdev);
|
|
- unsigned long offset = BIT_ULL_WORD(id);
|
|
- u64 mask = BIT_ULL_MASK(id);
|
|
- void __iomem *reg_status = data->status + offset * sizeof(u64);
|
|
- u64 value = readq(reg_status);
|
|
+ unsigned long offset = id / 32;
|
|
+ u32 mask = BIT(id % 32);
|
|
+ void __iomem *reg_status = data->status + offset * sizeof(u32);
|
|
+ u32 value = readl(reg_status);
|
|
|
|
return !((value ^ data->asserted[offset]) & mask);
|
|
}
|
|
@@ -107,7 +106,7 @@ static const struct reset_control_ops jh
|
|
|
|
int reset_starfive_jh71x0_register(struct device *dev, struct device_node *of_node,
|
|
void __iomem *assert, void __iomem *status,
|
|
- const u64 *asserted, unsigned int nr_resets,
|
|
+ const u32 *asserted, unsigned int nr_resets,
|
|
struct module *owner)
|
|
{
|
|
struct jh71x0_reset *data;
|
|
--- a/drivers/reset/starfive/reset-starfive-jh71x0.h
|
|
+++ b/drivers/reset/starfive/reset-starfive-jh71x0.h
|
|
@@ -8,7 +8,7 @@
|
|
|
|
int reset_starfive_jh71x0_register(struct device *dev, struct device_node *of_node,
|
|
void __iomem *assert, void __iomem *status,
|
|
- const u64 *asserted, unsigned int nr_resets,
|
|
+ const u32 *asserted, unsigned int nr_resets,
|
|
struct module *owner);
|
|
|
|
#endif /* __RESET_STARFIVE_JH71X0_H */
|