mirror of
https://github.com/openwrt/openwrt.git
synced 2025-01-15 09:19:57 +00:00
ba249bc955
If no mcast_rate is set for the wifi-iface then there is no rate_idx (0)
set for the bss. This can break for example 5GHz meshpoint interfaces
because 0 maps to a CCK rate (11Mbit/s).
It must also be avoided that the ath10k-ct internal state for the rates is
not synced with the mac80211 rates state. Otherwise, the user specified
rate (e.g. a wifi-iface mcast_rate for a meshpoint interface) will only be
set on startup. And a short while after that, ath10k-ct specific code in
ath10k_check_apply_special_rates is missing a valid rate in its own
structures and is then recalculating a new default rate. This default rate
is in most situations not the requested rate.
Fixes: 4df3c71cd4 ("ath10k-ct: Update to 2018-12-11 and use version based on 4.19")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
91 lines
2.9 KiB
Diff
91 lines
2.9 KiB
Diff
From 79c9d7aabae1d1da9eea97d83b61e1517a8a2221 Mon Sep 17 00:00:00 2001
|
|
From: Mathias Kresin <dev@kresin.me>
|
|
Date: Fri, 22 Jun 2018 18:59:44 +0200
|
|
Subject: [PATCH] ath10k: use tpt LED trigger by default
|
|
|
|
Use the tpt LED trigger for each created phy led. Ths way LEDs attached
|
|
to the ath10k GPIO pins are indicating the phy status and blink on
|
|
traffic.
|
|
|
|
Signed-off-by: Mathias Kresin <dev@kresin.me>
|
|
---
|
|
ath10k-4.16/core.h | 4 ++++
|
|
ath10k-4.16/leds.c | 4 +---
|
|
ath10k-4.16/mac.c | 2 +-
|
|
3 files changed, 6 insertions(+), 4 deletions(-)
|
|
|
|
--- a/ath10k-4.16/core.h
|
|
+++ b/ath10k-4.16/core.h
|
|
@@ -1336,6 +1336,10 @@ struct ath10k {
|
|
u8 csi_data[4096];
|
|
u16 csi_data_len;
|
|
|
|
+#ifdef CPTCFG_MAC80211_LEDS
|
|
+ const char *led_default_trigger;
|
|
+#endif
|
|
+
|
|
/* must be last */
|
|
u8 drv_priv[0] __aligned(sizeof(void *));
|
|
};
|
|
--- a/ath10k-4.16/leds.c
|
|
+++ b/ath10k-4.16/leds.c
|
|
@@ -81,9 +81,7 @@ int ath10k_leds_register(struct ath10k *
|
|
|
|
ar->leds.cdev.name = ar->leds.label;
|
|
ar->leds.cdev.brightness_set_blocking = ath10k_leds_set_brightness_blocking;
|
|
-
|
|
- /* FIXME: this assignment doesn't make sense as it's NULL, remove it? */
|
|
- ar->leds.cdev.default_trigger = ar->leds.wifi_led.default_trigger;
|
|
+ ar->leds.cdev.default_trigger = ar->led_default_trigger;
|
|
|
|
ret = led_classdev_register(wiphy_dev(ar->hw->wiphy), &ar->leds.cdev);
|
|
if (ret)
|
|
--- a/ath10k-4.16/mac.c
|
|
+++ b/ath10k-4.16/mac.c
|
|
@@ -9624,7 +9624,7 @@ int ath10k_mac_register(struct ath10k *a
|
|
wiphy_ext_feature_set(ar->hw->wiphy, NL80211_EXT_FEATURE_CQM_RSSI_LIST);
|
|
|
|
#ifdef CPTCFG_MAC80211_LEDS
|
|
- ieee80211_create_tpt_led_trigger(ar->hw,
|
|
+ ar->led_default_trigger = ieee80211_create_tpt_led_trigger(ar->hw,
|
|
IEEE80211_TPT_LEDTRIG_FL_RADIO, ath10k_tpt_blink,
|
|
ARRAY_SIZE(ath10k_tpt_blink));
|
|
#endif
|
|
--- a/ath10k-4.19/core.h
|
|
+++ b/ath10k-4.19/core.h
|
|
@@ -1452,6 +1452,10 @@ struct ath10k {
|
|
u8 csi_data[4096];
|
|
u16 csi_data_len;
|
|
|
|
+#ifdef CPTCFG_MAC80211_LEDS
|
|
+ const char *led_default_trigger;
|
|
+#endif
|
|
+
|
|
/* must be last */
|
|
u8 drv_priv[0] __aligned(sizeof(void *));
|
|
};
|
|
--- a/ath10k-4.19/leds.c
|
|
+++ b/ath10k-4.19/leds.c
|
|
@@ -81,9 +81,7 @@ int ath10k_leds_register(struct ath10k *
|
|
|
|
ar->leds.cdev.name = ar->leds.label;
|
|
ar->leds.cdev.brightness_set_blocking = ath10k_leds_set_brightness_blocking;
|
|
-
|
|
- /* FIXME: this assignment doesn't make sense as it's NULL, remove it? */
|
|
- ar->leds.cdev.default_trigger = ar->leds.wifi_led.default_trigger;
|
|
+ ar->leds.cdev.default_trigger = ar->led_default_trigger;
|
|
|
|
ret = led_classdev_register(wiphy_dev(ar->hw->wiphy), &ar->leds.cdev);
|
|
if (ret)
|
|
--- a/ath10k-4.19/mac.c
|
|
+++ b/ath10k-4.19/mac.c
|
|
@@ -9823,7 +9823,7 @@ int ath10k_mac_register(struct ath10k *a
|
|
wiphy_ext_feature_set(ar->hw->wiphy, NL80211_EXT_FEATURE_CQM_RSSI_LIST);
|
|
|
|
#ifdef CPTCFG_MAC80211_LEDS
|
|
- ieee80211_create_tpt_led_trigger(ar->hw,
|
|
+ ar->led_default_trigger = ieee80211_create_tpt_led_trigger(ar->hw,
|
|
IEEE80211_TPT_LEDTRIG_FL_RADIO, ath10k_tpt_blink,
|
|
ARRAY_SIZE(ath10k_tpt_blink));
|
|
#endif
|