mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-20 14:13:16 +00:00
8eb57d0cd7
The skb is usually started by a padding which allows the protocols in the network stack to add their headers in front of the payload. The skb can be reallocated in case the preallocated padding is not large enough. This can for example happen in the function __skb_cow which will check the requested extra headroom and allocate more buffer when the requested headroom is bigger than the available one. The extra buffer is aligned again to the multiple of the NET_SKB_PAD of the target architecture. The macro used to create the multiple of the NET_SKB_PAD is written in a way which allows only values power two as alignment parameter. The currently used value of 48 bytes can not be written as n ** 2 but as 2 ** 4 + 2 ** 5. The extra buffer is therefore not always the multiple of 48 but can be 16, 64, 80, 128, 144 and so on. The generated values are also not monotonic (48 requested bytes are mapped to 80 allocated bytes and 49 requested bytes are mapped to 64 allocated bytes). These unexpected small values result in more reallocations of the buffer. This was noticed prominently during tests between two QCA9558 720 MHz devices which were connected via ethernet to PCs and had a HT40 802.11n 3x3 link between each other. The throughput PC-to-PC during iperf TCP runs increased reliable from 186 Mibit/s to 214 Mibit/s in one direction and from 195 Mibit/s to 220 Mibit/s in the other direction. This is a performance increase of ~14% just by reducing the amount of reallocations. Signed-off-by: Sven Eckelmann <sven@open-mesh.com> SVN-Revision: 37948
12 lines
384 B
Diff
12 lines
384 B
Diff
--- a/include/linux/skbuff.h
|
|
+++ b/include/linux/skbuff.h
|
|
@@ -1848,7 +1848,7 @@ static inline int pskb_network_may_pull(
|
|
* NET_IP_ALIGN(2) + ethernet_header(14) + IP_header(20/40) + ports(8)
|
|
*/
|
|
#ifndef NET_SKB_PAD
|
|
-#define NET_SKB_PAD max(32, L1_CACHE_BYTES)
|
|
+#define NET_SKB_PAD max(64, L1_CACHE_BYTES)
|
|
#endif
|
|
|
|
extern int ___pskb_trim(struct sk_buff *skb, unsigned int len);
|