mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-23 07:22:33 +00:00
1c28058710
Changelog: https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.15.148
Removed upstreamed:
generic/hack-5.15/321-powerpc_crtsavres_prereq.patch[1]
Manually rebased:
target/linux/octeontx/patches-5.15/0004-PCI-add-quirk-for-Gateworks-PLX-PEX860x-switch-with-.patch[2]
All other patches automatically rebased.
1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.148&id=0b11a145eb00d51f7ef18cfcae587b93f9adb1e9
2. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit?h=v5.15.148&id=b67064bd372300a75293efbbc70624996dccffd4
Build system: x86_64
Build-tested: ramips/tplink_archer-a6-v3
Run-tested: ramips/tplink_archer-a6-v3
Signed-off-by: John Audia <therealgraysky@proton.me>
(cherry picked from commit 99c9d8abd6
)
[Refresh on OpenWrt 23.05]
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
156 lines
5.4 KiB
Diff
156 lines
5.4 KiB
Diff
From 0db3e9ac75b107d2158b227426f58df9bb00529f Mon Sep 17 00:00:00 2001
|
|
From: Oskari Lemmela <oskari@lemmela.net>
|
|
Date: Sun, 20 Aug 2023 15:25:09 +0300
|
|
Subject: [PATCH] Revert "net: stmmac: Use hrtimer for TX coalescing"
|
|
|
|
This reverts commit d5a05e69ac6e4c431c380ced2b534c91f7bc3280.
|
|
|
|
hrtimer uses raw_spin_lock which causes high CPU usage.
|
|
ipq806x platform's TCP transmit speed dropped from 950 Mbps to 250 Mbps
|
|
due to high ksoftirq.
|
|
|
|
Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
|
|
---
|
|
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 +--
|
|
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 25 +++++++------------
|
|
2 files changed, 10 insertions(+), 18 deletions(-)
|
|
|
|
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
|
|
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
|
|
@@ -13,7 +13,6 @@
|
|
#define DRV_MODULE_VERSION "Jan_2016"
|
|
|
|
#include <linux/clk.h>
|
|
-#include <linux/hrtimer.h>
|
|
#include <linux/if_vlan.h>
|
|
#include <linux/stmmac.h>
|
|
#include <linux/phylink.h>
|
|
@@ -59,7 +58,7 @@ struct stmmac_tx_info {
|
|
struct stmmac_tx_queue {
|
|
u32 tx_count_frames;
|
|
int tbs;
|
|
- struct hrtimer txtimer;
|
|
+ struct timer_list txtimer;
|
|
u32 queue_index;
|
|
struct stmmac_priv *priv_data;
|
|
struct dma_extended_desc *dma_etx ____cacheline_aligned_in_smp;
|
|
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
|
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
|
@@ -142,7 +142,7 @@ static void stmmac_init_fs(struct net_de
|
|
static void stmmac_exit_fs(struct net_device *dev);
|
|
#endif
|
|
|
|
-#define STMMAC_COAL_TIMER(x) (ns_to_ktime((x) * NSEC_PER_USEC))
|
|
+#define STMMAC_COAL_TIMER(x) (jiffies + usecs_to_jiffies(x))
|
|
|
|
int stmmac_bus_clks_config(struct stmmac_priv *priv, bool enabled)
|
|
{
|
|
@@ -2726,9 +2726,7 @@ static int stmmac_tx_clean(struct stmmac
|
|
|
|
/* We still have pending packets, let's call for a new scheduling */
|
|
if (tx_q->dirty_tx != tx_q->cur_tx)
|
|
- hrtimer_start(&tx_q->txtimer,
|
|
- STMMAC_COAL_TIMER(priv->tx_coal_timer[queue]),
|
|
- HRTIMER_MODE_REL);
|
|
+ mod_timer(&tx_q->txtimer, STMMAC_COAL_TIMER(priv->tx_coal_timer[queue]));
|
|
|
|
__netif_tx_unlock_bh(netdev_get_tx_queue(priv->dev, queue));
|
|
|
|
@@ -3020,9 +3018,7 @@ static void stmmac_tx_timer_arm(struct s
|
|
{
|
|
struct stmmac_tx_queue *tx_q = &priv->dma_conf.tx_queue[queue];
|
|
|
|
- hrtimer_start(&tx_q->txtimer,
|
|
- STMMAC_COAL_TIMER(priv->tx_coal_timer[queue]),
|
|
- HRTIMER_MODE_REL);
|
|
+ mod_timer(&tx_q->txtimer, STMMAC_COAL_TIMER(priv->tx_coal_timer[queue]));
|
|
}
|
|
|
|
/**
|
|
@@ -3031,9 +3027,9 @@ static void stmmac_tx_timer_arm(struct s
|
|
* Description:
|
|
* This is the timer handler to directly invoke the stmmac_tx_clean.
|
|
*/
|
|
-static enum hrtimer_restart stmmac_tx_timer(struct hrtimer *t)
|
|
+static void stmmac_tx_timer(struct timer_list *t)
|
|
{
|
|
- struct stmmac_tx_queue *tx_q = container_of(t, struct stmmac_tx_queue, txtimer);
|
|
+ struct stmmac_tx_queue *tx_q = from_timer(tx_q, t, txtimer);
|
|
struct stmmac_priv *priv = tx_q->priv_data;
|
|
struct stmmac_channel *ch;
|
|
struct napi_struct *napi;
|
|
@@ -3049,8 +3045,6 @@ static enum hrtimer_restart stmmac_tx_ti
|
|
spin_unlock_irqrestore(&ch->lock, flags);
|
|
__napi_schedule(napi);
|
|
}
|
|
-
|
|
- return HRTIMER_NORESTART;
|
|
}
|
|
|
|
/**
|
|
@@ -3073,8 +3067,7 @@ static void stmmac_init_coalesce(struct
|
|
priv->tx_coal_frames[chan] = STMMAC_TX_FRAMES;
|
|
priv->tx_coal_timer[chan] = STMMAC_COAL_TX_TIMER;
|
|
|
|
- hrtimer_init(&tx_q->txtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
|
|
- tx_q->txtimer.function = stmmac_tx_timer;
|
|
+ timer_setup(&tx_q->txtimer, stmmac_tx_timer, 0);
|
|
}
|
|
|
|
for (chan = 0; chan < rx_channel_count; chan++)
|
|
@@ -3904,7 +3897,7 @@ irq_error:
|
|
phylink_stop(priv->phylink);
|
|
|
|
for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++)
|
|
- hrtimer_cancel(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
+ del_timer_sync(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
|
|
stmmac_hw_teardown(dev);
|
|
init_error:
|
|
@@ -3960,7 +3953,7 @@ static int stmmac_release(struct net_dev
|
|
stmmac_disable_all_queues(priv);
|
|
|
|
for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++)
|
|
- hrtimer_cancel(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
+ del_timer_sync(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
|
|
netif_tx_disable(dev);
|
|
|
|
@@ -6655,7 +6648,7 @@ void stmmac_xdp_release(struct net_devic
|
|
stmmac_disable_all_queues(priv);
|
|
|
|
for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++)
|
|
- hrtimer_cancel(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
+ del_timer_sync(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
|
|
/* Free the IRQ lines */
|
|
stmmac_free_irq(dev, REQ_IRQ_ERR_ALL, 0);
|
|
@@ -6750,8 +6743,7 @@ int stmmac_xdp_open(struct net_device *d
|
|
stmmac_set_tx_tail_ptr(priv, priv->ioaddr,
|
|
tx_q->tx_tail_addr, chan);
|
|
|
|
- hrtimer_init(&tx_q->txtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
|
|
- tx_q->txtimer.function = stmmac_tx_timer;
|
|
+ timer_setup(&tx_q->txtimer, stmmac_tx_timer, 0);
|
|
}
|
|
|
|
/* Enable the MAC Rx/Tx */
|
|
@@ -6774,7 +6766,7 @@ int stmmac_xdp_open(struct net_device *d
|
|
|
|
irq_error:
|
|
for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++)
|
|
- hrtimer_cancel(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
+ del_timer_sync(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
|
|
stmmac_hw_teardown(dev);
|
|
init_error:
|
|
@@ -7498,7 +7490,7 @@ int stmmac_suspend(struct device *dev)
|
|
stmmac_disable_all_queues(priv);
|
|
|
|
for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++)
|
|
- hrtimer_cancel(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
+ del_timer_sync(&priv->dma_conf.tx_queue[chan].txtimer);
|
|
|
|
if (priv->eee_enabled) {
|
|
priv->tx_path_in_lpi_mode = false;
|