mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-22 15:02:32 +00:00
3c3b84fd87
This backports the upstream commit:
leds: lp55xx: Initialize enable GPIO direction to output
Without it under kernel 5.10 on Asus MAP-AC2200
the LED driver will fail probing:
[ 1.947521] lp5523x: probe of 0-0032 failed with error -22
After the backported fix:
[ 1.873236] lp5523x 0-0032: lp5523 Programmable led chip found
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Tested-by: Szabolcs Hubai <szab.hu@gmail.com> [ipq4029/gl-b1300]
Tested-by: Nick Hainke <vincent@systemli.org> [ipq4019/fritzbox-7530
ipq4019/fritzbox-4040
ipq4019/sxtsq-5ac]
Tested-by: Stefan Lippers-Hollmann <s.l-h@gmx.de> [ipq4019/map-ac2200]
29 lines
1.0 KiB
Diff
29 lines
1.0 KiB
Diff
From a5d3d1adc95f4ac5968b7a77ee95a3abbbb96f49 Mon Sep 17 00:00:00 2001
|
|
From: Doug Zobel <dougdev334@gmail.com>
|
|
Date: Mon, 10 May 2021 15:40:00 -0500
|
|
Subject: [PATCH] leds: lp55xx: Initialize enable GPIO direction to output
|
|
|
|
The "Convert to use GPIO descriptors" commit changed the
|
|
initialization of the enable GPIO from GPIOF_DIR_OUT to
|
|
GPIOD_ASIS. This breaks systems where the GPIO does not
|
|
default to output. Changing the enable initialization
|
|
to GPIOD_OUT_LOW.
|
|
|
|
Signed-off-by: Doug Zobel <dougdev334@gmail.com>
|
|
Signed-off-by: Pavel Machek <pavel@ucw.cz>
|
|
---
|
|
drivers/leds/leds-lp55xx-common.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/drivers/leds/leds-lp55xx-common.c
|
|
+++ b/drivers/leds/leds-lp55xx-common.c
|
|
@@ -694,7 +694,7 @@ struct lp55xx_platform_data *lp55xx_of_p
|
|
of_property_read_u8(np, "clock-mode", &pdata->clock_mode);
|
|
|
|
pdata->enable_gpiod = devm_gpiod_get_optional(dev, "enable",
|
|
- GPIOD_ASIS);
|
|
+ GPIOD_OUT_LOW);
|
|
if (IS_ERR(pdata->enable_gpiod))
|
|
return ERR_CAST(pdata->enable_gpiod);
|
|
|