mirror of
https://github.com/openwrt/openwrt.git
synced 2024-12-28 09:39:00 +00:00
43ae50978a
https://patchwork.kernel.org/patch/11224189/ -- On 2019-10-28 06:07, wbob wrote: > Hello Roman, > > while reading around drivers/net/wireless/ralink/rt2x00/rt2800lib.c > I stumbled on what I think is an edit of yours made in error in march > 2017: > > https://github.com/torvalds/linux/commit/41977e86#diff-dae5dc10da180f3b055809a48118e18aR5281 > > RT6352 in line 5281 should not have been introduced as the "else if" > below line 5291 can then not take effect for a RT6352 device. Another > possibility is for line 5291 to be not for RT6352, but this seems > very unlikely. Are you able to clarify still after this substantial time? > > 5277: static int rt2800_init_registers(struct rt2x00_dev *rt2x00dev) > ... > 5279: } else if (rt2x00_rt(rt2x00dev, RT5390) || > 5280: rt2x00_rt(rt2x00dev, RT5392) || > 5281: rt2x00_rt(rt2x00dev, RT6352)) { > ... > 5291: } else if (rt2x00_rt(rt2x00dev, RT6352)) { > ... Hence remove errornous line 5281 to make the driver actually execute the correct initialization routine for MT7620 chips. As it was requested by Stanislaw Gruszka remove setting values of MIMO_PS_CFG and TX_PIN_CFG. MIMO_PS_CFG is responsible for MIMO power-safe mode (which is disabled), hence we can drop setting it. TX_PIN_CFG is set correctly in other functions, and as setting this value breaks some devices, rather don't set it here during init, but only modify it later on. Fixes: 41977e86c984 ("rt2x00: add support for MT7620") Reported-by: wbob <wbob@jify.de> Reported-by: Roman Yeryomin <roman@advem.lv> Signed-off-by: Daniel Golle <daniel@makrotopia.org> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com> -- Signed-off-by: Daniel Golle <daniel@makrotopia.org> |
||
|---|---|---|
| .. | ||
| 017-rt2x00-initialize-last_reset.patch | ||
| 020-rt2800-remove-errornous-duplicate-condition.patch | ||
| 100-rt2x00_options.patch | ||
| 501-rt2x00-allow-to-build-rt2800soc-module-for-RT3883.patch | ||
| 601-rt2x00-introduce-rt2x00_platform_h.patch | ||
| 602-rt2x00-introduce-rt2x00eeprom.patch | ||
| 603-rt2x00-of_load_eeprom_filename.patch | ||
| 604-rt2x00-load-eeprom-on-SoC-from-a-mtd-device-defines-.patch | ||
| 606-rt2x00-allow_disabling_bands_through_platform_data.patch | ||
| 607-rt2x00-add_platform_data_mac_addr.patch | ||
| 608-rt2x00-allow_disabling_bands_through_dts.patch | ||
| 609-rt2x00-make-wmac-loadable-via-OF-on-rt288x-305x-SoC.patch | ||
| 610-rt2x00-change-led-polarity-from-OF.patch | ||
| 611-rt2x00-add-AP+STA-support.patch | ||
| 650-rt2x00-add-support-for-external-PA-on-MT7620.patch | ||
| 982-rt2x00-add-rf-self-txdc-calibration.patch | ||
| 983-rt2x00-add-r-calibration.patch | ||
| 984-rt2x00-add-rxdcoc-calibration.patch | ||
| 985-rt2x00-add-rxiq-calibration.patch | ||
| 986-rt2x00-add-TX-LOFT-calibration.patch | ||