From 5a4c1a747f378723154f2c0cc563aaff3d4d43f8 Mon Sep 17 00:00:00 2001 From: Jonathan Bell Date: Tue, 14 May 2019 17:17:59 +0100 Subject: [PATCH] net: genet: enable link energy detect powerdown for external PHYs There are several warts surrounding bcmgenet_mii_probe() as this function is called from ndo_open, but it's calling registration-type functions. The probe should be called at probe time and refactored such that the PHY device data can be extracted to limit the scope of this flag to Broadcom PHYs. For now, pass this flag in as it puts our attached PHY into a low-power state when disconnected. Signed-off-by: Jonathan Bell --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -309,6 +309,8 @@ int bcmgenet_mii_probe(struct net_device /* Communicate the integrated PHY revision */ if (priv->internal_phy) phy_flags = priv->gphy_rev; + else + phy_flags = PHY_BRCM_AUTO_PWRDWN_ENABLE; /* This is an ugly quirk but we have not been correctly interpreting * the phy_interface values and we have done that across different