From 77fad8f907fe93aafe8c770b24ae02295e40b7d8 Mon Sep 17 00:00:00 2001 From: Naushir Patuck Date: Tue, 14 Mar 2023 10:10:01 +0000 Subject: [PATCH 0956/1085] media: i2c: imx296: Get sensor crop working Add a missing register write (MIPIC_AREA3W) when setting up a crop window in the sensor to get this functionality working. Signed-off-by: Naushir Patuck --- drivers/media/i2c/imx296.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/media/i2c/imx296.c +++ b/drivers/media/i2c/imx296.c @@ -175,6 +175,7 @@ MODULE_PARM_DESC(trigger_mode, "Set trig #define IMX296_CKREQSEL IMX296_REG_8BIT(0x4101) #define IMX296_CKREQSEL_HS BIT(2) #define IMX296_GTTABLENUM IMX296_REG_8BIT(0x4114) +#define IMX296_MIPIC_AREA3W IMX296_REG_16BIT(0x4182) #define IMX296_CTRL418C IMX296_REG_8BIT(0x418c) struct imx296_clk_params { @@ -530,8 +531,11 @@ static int imx296_setup(struct imx296 *s imx296_write(sensor, IMX296_FID0_ROIPV1, crop->top, &ret); imx296_write(sensor, IMX296_FID0_ROIWH1, crop->width, &ret); imx296_write(sensor, IMX296_FID0_ROIWV1, crop->height, &ret); + imx296_write(sensor, IMX296_MIPIC_AREA3W, crop->height, &ret); } else { imx296_write(sensor, IMX296_FID0_ROI, 0, &ret); + imx296_write(sensor, IMX296_MIPIC_AREA3W, + IMX296_PIXEL_ARRAY_HEIGHT, &ret); } imx296_write(sensor, IMX296_CTRL0D,