Commit Graph

24 Commits

Author SHA1 Message Date
Daniel Golle
88baf6ce2c
ubox: only start log to file when filesystem has been mounted
If log_file is on an filesystem mounted using /etc/config/fstab we have
to wait for that to happen before starting the logread process.
Inhibit the start of the file-writer process and use a mount trigger to
fire it up once the filesystem actually becomes available.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2022-01-30 20:19:37 +00:00
Jo-Philipp Wich
ec83fb9ced ubox: fix init script validation of log_ip option
The underlying logread process uses usock() to handle remote connections
which is able to handle both hostnames and IP addresses.

Ref: https://github.com/openwrt/luci/issues/5077
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-05-28 15:23:14 +02:00
Petr Štetiar
296e1f253c netifd,lldpd,rpcd,log: use generic service_running
commit eb204d14f75c ("base-files: implement generic service_running")
introduced generic service_running so it's not needed to copy&paste same
3 lines over and over again.

I've removed service_running from netifd/network init script as well,
because it was not working properly, looked quite strange and I didn't
understand the intention:

 $ /etc/init.d/network stop
 $ service network running && echo "yes" || echo "nope"
     ( have to wait for 30s )
 Command failed: Request timed out
 yes

Signed-off-by: Petr Štetiar <ynezz@true.cz>
2019-09-15 22:53:01 +02:00
Rafał Miłecki
1b937cb141 ubox: implement service_running() in log init.d script
It allows checking if service is running.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2019-07-15 16:21:56 +02:00
Jeffery To
d13e86d4c2 procd: Add wrapper for uci_validate_section()
This adds a wrapper (uci_load_validate) for uci_validate_section() that
allows callers (through a callback function) to access the values set by
uci_validate_section(), without having to manually declare a
(potentially long) list of local variables.

The callback function receives two arguments when called, the config
section name and the return value of uci_validate_section().

If no callback function is given, then the wrapper exits with the value
returned by uci_validate_section().

This also updates several init scripts to use the new wrapper function.

Signed-off-by: Jeffery To <jeffery.to@gmail.com>
2019-01-22 09:05:59 +01:00
Karl Palsson
987e10af07 logd: create log directory for log_file
If log_file is specified, make sure its directory exists.

Signed-off-by: Karl Palsson <karlp@etactica.com>
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> [PKG_RELEASE increase]
2018-06-07 17:19:42 +02:00
John Crispin
88a41074e8 ubox: update to latest git HEAD
128bc35 logread: fix reconnect logd logic
66347ec logread: move the code setting up the request blob out of the main loop
975a258 logread: move output connection setup code out of main loop
b81bea7 logread: cleanup pid file handling
d73e7d2 ubox: Replace strerror(errno) with %m format.

Signed-off-by: John Crispin <john@phrozen.org>
2018-02-14 09:30:07 +01:00
Hannu Nyman
efa740b08b ubox: increase default size of system log buffer to 64 kB
Increase the default system log buffer size
from 16 kB (default both in logd source and in the startup script)
to 64 kB by adjusting the default value in startup script.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2016-06-07 23:13:29 +02:00
John Crispin
a4571b7631 ubox: make logging code honour the hostname properly
Signed-off-by: John Crispin <john@phrozen.org>
2016-05-10 10:43:17 +02:00
John Crispin
eb099c5d6b ubox: add log_trailer_null option to uci
this allow us to use syslog tcp with \0 trailer
instead of \n trailer (logread -0 option)

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>

SVN-Revision: 45329
2015-04-09 10:32:18 +00:00
John Crispin
2ae05c57f8 package/*: remove useless explicit set of function returncode
somebody started to set a function returncode in the validation
stuff and everybody copies it, e.g.

myfunction()
{
	fire_command

	return $?
}

a function automatically returns with the last returncode,
so we can safely remove the command 'return $?'. reference:

http://tldp.org/LDP/abs/html/exit-status.html
"The last command executed in the function or script determines the exit status."

Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>

SVN-Revision: 42278
2014-08-25 06:35:50 +00:00
John Crispin
f63bb0adbd ubox: fix remote logging
in r41439 a flag for enabling remote logging was added,
but the actual check was done on a different variable.

Signed-off-by: Reiner Herrmann <reiner@reiner-h.de>

SVN-Revision: 41467
2014-07-02 12:56:20 +00:00
John Crispin
ea535a9565 ubox: add a flag that allows us to disable remote log while keeping the ip settings inside uci
this makes webui foo a lot easier

Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 41439
2014-07-01 10:26:10 +00:00
John Crispin
ca4078c110 ubox: update to latest git head
logread now shows the right time.

Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 39951
2014-03-18 19:22:38 +00:00
John Crispin
bc6223666e ubox: update to latest git head
use the fd handover api of ubus to transfer log data
the uci option log_buffer_size can be used to override the default size of 16k

Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 39898
2014-03-12 19:33:18 +00:00
John Crispin
f9f8948c6e ubox: logd did not register its config.reload trigger properly
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 39616
2014-02-18 13:33:43 +00:00
John Crispin
eceea6d6e1 ubox: revert log buffer size changes
the fix horribly broke existing setups

Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 39366
2014-01-22 15:33:16 +00:00
John Crispin
1de0eac947 ubox: update to latest git head
adds option to set internal buffer size

Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 39333
2014-01-19 19:10:09 +00:00
John Crispin
e231f82cc0 ubox: fix up pidcount handling inside log.init
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 39022
2013-12-09 17:29:44 +00:00
Jo-Philipp Wich
cdbff3641b Revert "ubox: the validation code has problems with the "(" char. use string for now"
This reverts commit f7c2ac3ea9b5f2dc4ef4ce4ef195de8a4ac5546b.

SVN-Revision: 38937
2013-11-28 11:33:49 +00:00
John Crispin
fc3c72aba6 ubox: the validation code has problems with the "(" char. use string for now
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 38916
2013-11-26 07:50:05 +00:00
John Crispin
637440c415 ubox: fix typo that caused log_file to not be validated properly
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 38906
2013-11-25 08:34:31 +00:00
John Crispin
1b3a423ad5 procd: add validation to the log init script
Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 38879
2013-11-20 16:56:41 +00:00
John Crispin
5fbfffe7f4 procd: ubox: update to latest git head
move log service from procd to ubox
some debloating on procd
the preinit part of procd is now also a seperate binary

Signed-off-by: John Crispin <blogic@openwrt.org>

SVN-Revision: 38822
2013-11-16 20:20:30 +00:00